Summary: amfnd : mark SU UNINSTANTIATED if all comps are UNINSTANTIATED during compfailover [#359] Review request for Trac Ticket(s): #359 Peer Reviewer(s): AMF contributors Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): ALL Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset ebc7af10ff54ffd739f48b16c196a4fb71439bac Author: [email protected] Date: Tue, 15 Jul 2014 17:31:46 +0530 amfnd : mark SU UNINSTANTIATED if all comps are UNINSTANTIATED during compfailover [#359] If a SU has one component and it moves to UNINSTANTIATED state then AMF does not generate presense state change notification for UNINSTANTIATED state of SU. During component failover, a component moves to TERMINATING state as it is cleaned up by AMF. This leads to TERMINATING state of SU. After successful termination of the component it is marked as UNINSTANTIATED but SU remains in TERMINATING state. Repair of SU leads to re-instantiation of component. Thus component transtions from UNINSTANTIATED->INSTANTIATED-> INSTANTIATED state. But SU is transitioning from TERMINATING to INSTANTIATED state directly. Since presence state of SU represents combined presence states of components, SU should also be marked as UNINSTANTIATED when a single component is marked as UNINSTANTIATED. Same behaviour is true if all the component are UNINSTANTIATED due to component failover. Patch marks presence state of SU UNINSTANTIATED if all of its components are UNINSTANTIATED during component failover. Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/clc.cc | 4 +++- osaf/services/saf/amf/amfnd/err.cc | 14 +++++++++++++- osaf/services/saf/amf/amfnd/include/avnd_su.h | 1 + osaf/services/saf/amf/amfnd/susm.cc | 9 ++++----- 4 files changed, 21 insertions(+), 7 deletions(-) Testing Commands: ----------------- Tested component failover in One component configuration. Tested component failover in mixed configuration with one npi comp and one pi comp in PI SU. Tested component failover in mixed configuration with one npi comp and three pi comps in PI SU. Testing, Expected Results: -------------------------- SU moves to UNINSTANTIATED state when component(s) moves to UNINSTANTIATED state. State change notification for UNINSTANTIATED state of SU observed. Conditions of Submission: ------------------------- Ack from atleast one reviewer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
