Hi AndersBj, Reviewed and tested the patch. Ack with the following comments.
1. when the attribute opensafImmSyncBatchSize is changed without the patch and PBE enabled the following error is displayed: immcfg -a opensafImmSyncBatchSize=654 opensafImm=opensafImm,safApp=safImmService Jul 15 17:19:40 Slot-3 osafimmpbed: NO PBE will not allow modifications to object opensafImm=opensafImm,safApp=safImmService Jul 15 17:19:40 Slot-3 osafimmpbed: NO PBE will not allow modifications to object opensafImm=opensafImm,safApp=safImmService Jul 15 17:19:40 Slot-3 osafimmnd[3015]: WA immsv_evt_enc_inline_text: Length missmatch from source line:1093 (86 963414472 'PBE will not allow modifications to object opensafImm=opensafImm,safApp=safImmService') Jul 15 17:19:40 Slot-3 osafimmnd[3015]: immsv_evt.c:1093: immsv_evt_enc_attrName: Assertion 'immsv_evt_enc_inline_text(__LINE__, o_ub, os)' failed. Jul 15 17:19:40 Slot-3 osafimmpbed: WA PBE lost contact with parent IMMND - Exiting Jul 15 17:19:40 Slot-3 osafamfnd[3109]: NO Restarting a component of 'safSu=SC-1,safSg=NoRed,safApp=OpenSAF' (comp restart count: 1) Jul 15 17:19:40 Slot-3 osafamfnd[3109]: NO 'safComp=IMMND,safSu=SC-1,safSg=NoRed,safApp=OpenSAF' faulted due to 'avaDown' : Recovery is 'componentRestart' Jul 15 17:19:40 Slot-3 osafimmd[3000]: WA IMMND coordinator at 2010f apparently crashed => electing new coord Jul 15 17:19:40 Slot-3 osafimmd[3000]: ER Failed to find candidate for new IMMND coordinator Jul 15 17:19:40 Slot-3 osafimmd[3000]: ER Active IMMD has to restart the IMMSv. All IMMNDs will restart Jul 15 17:19:40 Slot-3 osafimmd[3000]: ER IMM RELOAD => ensure cluster restart by IMMD exit at both SCs, exiting Jul 15 17:19:40 Slot-3 osafamfnd[3109]: NO 'safComp=IMMD,safSu=SC-1,safSg=2N,safApp=OpenSAF' faulted due to 'avaDown' : Recovery is 'nodeFailfast' Jul 15 17:19:40 Slot-3 osafamfnd[3109]: ER safComp=IMMD,safSu=SC-1,safSg=2N,safApp=OpenSAF Faulted due to:avaDown Recovery is:nodeFailfast Jul 15 17:19:40 Slot-3 osafamfnd[3109]: Rebooting OpenSAF NodeId = 131343 EE Name = , Reason: Component faulted: recovery is node failfast, OwnNodeId = 131343, SupervisionTime = 60 Jul 15 17:19:40 Slot-3 opensaf_reboot: Rebooting local node; timeout=60 2.opensafImmSyncBatchSize may be pre-validated based on the MDS fragmentation change. The present MDS fragmentation size is 65536.(presently the default value is 65479. Thanks, Neel. On Monday 07 July 2014 03:59 PM, Anders Bjornerstedt wrote: > Summary: IMM: PBE allows config changes on > opensafImm=opensafImm,safApp=safImmService [#934] > Review request for Trac Ticket(s): 934 > Peer Reviewer(s): Neel; Zoran > Pull request to: > Affected branch(es): default(4.5) > Development branch: > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset c00c6b5c7c16ca68cc0fcdfa0847611c6fc848ee > Author: Anders Bjornerstedt <anders.bjornerst...@ericsson.com> > Date: Mon, 07 Jul 2014 12:13:11 +0200 > > IMM: PBE allows config changes on > opensafImm=opensafImm,safApp=safImmService > [#934] > > The OpenSAF IMM service object > 'opensafImm=opensafImm,safApp=safImmService' > currently has two writable config attributes: > > - opensafImmSyncBatchSize > - longDnsAllowed > > Changes to these attributes required the PBE to be disabled. This > because > the PBE is both regular-OI and PBE-OI for this special object. The PBE > used > to reject all such requests. This ticket changes the PBE to accept > modifications to this config object. This would result in the PBE > getting a > second (duplicate) callback, the first one as regular OI and the second > one > as PBE, resulting in the derailing and abort of the CCB. So this > changeset > also fixes so that modifications to the special OpenSAF IMM service > object > will only generate one modify callback to the PBE. The regular OI > callback > is discarded for this special case. > > The ticket also mentions that validation should be done. But there is no > validation of substance to perform for the above two config attributes. > The > 'opensafImmSyncBatchSize' can be set to whatever value the deployer > thinks > is appropriate. The 'longDnsAllowed' attribute is managed by logic that > only > cares if the value is 0/zero or not, corresponding to longDNs > disallowed or > allowed. So the PBE simply accepts whatever modification is proposed for > these attributes. > > Creates or deletes of instances of the class OpensafImm are still > rejected > by the PBE (not changed by this changeset) and so will not be > duplicated and > never require validation. However, when PBE is disabled, then curently > creates or deletes of instances of the OpensafImm class are accepted. > That > is a defect that will be fixed separately on the supported branches. > This > ticket is an enhancement and is fixed only on default(4.5). > > > Complete diffstat: > ------------------ > osaf/services/saf/immsv/immnd/ImmModel.cc | 85 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++----- > osaf/services/saf/immsv/immnd/ImmModel.hh | 2 +- > osaf/services/saf/immsv/immpbed/immpbe_daemon.cc | 13 +-------- > 3 files changed, 80 insertions(+), 20 deletions(-) > > > Testing Commands: > ----------------- > Testing the complete functionality of this patch will only be possible when > ticket #886 (IMM: Add support for long DNs in existing IMM APIs) is fixed. > > It should at least be possible to test just changing the value of > 'opensafImmSyncBatchSize' > or 'longDnsAllowed', with PBE enabled. > > > Testing, Expected Results: > -------------------------- > Change of config attributes in 'opensafImm=opensafImm,safApp=safImmService' is > possible when PBE is enabled. > > > Conditions of Submission: > ------------------------- > Ack from Neel. > > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
