Summary: amfnd : mark single comp SU RESTARTING during component restart [#358] Review request for Trac Ticket(s): #358 Peer Reviewer(s): AMF contributors Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): ALL Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset df08bcf786bd81b7ff628fbbd8ddf9ed45276ad2 Author: [email protected] Date: Wed, 16 Jul 2014 12:50:58 +0530 amfnd : mark single comp SU RESTARTING during component restart [#358] If a SU has only one component and component enters into restarting state due to component restart recovery, RESTARTING state of SU is not observed. In the mentioned case, SU remain in INSTANTIATED state while its only component is restarting. Thus a user application will not get state change notification for SU. At present only in surestart escalation a SU is marked RESTARTING. Patch marks presence state of SU RESTARTING when its single component is in RESTARTING state during component restart recovery. Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/susm.cc | 123 ++++++++++++++++++++++++++++++++++++++++++++++++--------------------- 1 files changed, 85 insertions(+), 38 deletions(-) Testing Commands: ----------------- One component configuration with restart recovery policy: PI) -kill one component: PASS -admin-restart of component:PASS -surestart escalation:PASS NPI) -kill one component:PASS -admin-restart of component:PASS -surestart escalation:PASS Multi components configuration with restart recovery policy: PI) -kill one component: PASS (no restart state observed). -kill all components:PASS (restart state observed). -admin-restart of component:PASS (no restart state observed). -surestart escalation direct:PASS (restart state observed). -surestart escalation indirect:PASS (restart state observed). NPI) -kill one component:PASS (no restart state observed). -kill all components:PASS (restart state observed) -admin-restart of component:PASS (no restart state observed) -surestart escalation direct:PASS -surestart escalation indirect:PASS (restart state observed). Also observed presence state change notification. Testing, Expected Results: -------------------------- PASS Conditions of Submission: ------------------------- Ack from anyone. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
