Summary:test/mds : tune the MDS test code according to new MDS Fragment SIZE 
[959] 
Review request for Trac Ticket(s): #959  
Peer Reviewer(s): Ramesh/Surya 
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): Default 
Development branch: <<IF ANY GIVE THE REPO URL>>

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            n
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   y
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------

changeset 85c377cbc33f1c13fe677a56f5334c1a17b7528f
Author: A V Mahesh <[email protected]>
Date:   Thu, 17 Jul 2014 11:24:47 +0530

        test:tune the MDS test code according to new MDS Fragment SIZE [959] The
        patch tunes the MDS test code (<staging >/tests/mds) according to new 
MDS.

        After the #654 MDS enhancement ,the MDS_DIRECT_BUF_MAXSIZE is the 
Fragment
        SIZE, so 2*1400+2 need to be replaced with 2*65479+2

         Tested the patch on the following configuration on physical Node 
,except
        one test case all are passed ( only one test case Failed ).

        ================================================================ 
PLATFORM
        : DELL Server OPTIPLEX 7010 Memory : 8 GB Hard Disk : 500 GB CPU
        : Quadcore - Intel(R) Core(TM) i5-3570 CPU @ 3.40GHz OS : SLES 11
        SP2 x86_64 TIPC : 2.0
        ================================================================

        Note : Please note that now the MDS single message size it self is equal
        to MDS_DIRECT_BUF_MAXSIZE = 2^16 size ( 65536 )


Complete diffstat:
------------------
 tests/mds/mdstipc.h     |   2 +-
 tests/mds/mdstipc_api.c |  40 ++++++++++++++++++++--------------------
 2 files changed, 21 insertions(+), 21 deletions(-)


Testing Commands:
-----------------
Please see commit log above. 

Testing, Expected Results:
--------------------------
Please see commit log above. 


Conditions of Submission:
-------------------------
Ack from reviewer.

Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to