Hi zoran, Forgot to export SA_ENABLE_EXTENDED_NAMES=1.
after exporting new immomtest and new immoitest are working fine. Its good to add SA_ENABLE_EXTENDED_NAMES=1 to immnd.conf Ack for patch 4. Thanks, Neel. On Wednesday 23 July 2014 08:19 PM, Zoran Milinkovic wrote: > Hi Neelakanta, > > The reason you are getting these errors is that you didn't enable extended > names on server side. > You must add to immnd.conf: > export SA_ENABLE_EXTENDED_NAMES=1 > > I'll add this line to immnd.conf. > > Best regards, > Zoran > > > -----Original Message----- > From: Neelakanta Reddy [mailto:[email protected]] > Sent: den 23 juli 2014 16:48 > To: Zoran Milinkovic > Cc: [email protected] > Subject: Re: [PATCH 0 of 4] Review Request for imm: add support for long DN > [#886] > > Hi zoran, > > Reviewed and tested the patch. > have the same comments as AndersBj. > Regarding the patch 4 "add test cases for long DN" > Ack for the first three patches. > > But for patch 4: > Ack, when immomtest and immoitest is fixed. > > The test cases are not running: > > I enabled longdDns, Following are the errors.: > > immcfg -m -a longDnsAllowed=1 opensafImm=opensafImm,safApp=safImmService > > root@Slot-3 ~]# immoitest --longDn 7 > > Suite 7: Long DN > 1 FAILED SA_AIS_OK - Object create callback (expected > SA_AIS_OK, got SA_AIS_ERR_NAME_TOO_LONG) > error: in test_saImmOiLongDn.c at 52: SA_AIS_ERR_NAME_TOO_LONG, expected > SA_AIS_OK - exiting > > > syslog: > > Jul 23 20:10:35 Slot-3 osafimmnd[3056]: NO implementer for class > 'TestClassConfig' is test_saImmOiLongDn.c => class extent is safe. > Jul 23 20:10:35 Slot-3 osafimmnd[3056]: NO ERR_NAME_TOO_LONG: RDN > attribute has long name. Support for extended names is not enabled > Jul 23 20:10:35 Slot-3 osafimmnd[3056]: NO implementer for class > 'TestClassConfig' is released => class extent is UNSAFE > > > [root@Slot-3 ~]# immomtest --longDn 8 > > Suite 8: Long DN > error: in test_saImmOmLongDn.c at 91: SA_AIS_ERR_NOT_EXIST, expected > SA_AIS_OK - exiting > > > syslog: > > Jul 23 20:11:56 Slot-3 osafimmnd[3056]: NO ERR_LIBRARY: attr 'attr' of > type SaNameT is too long:307. Extended names is not enabled > Jul 23 20:11:56 Slot-3 osafimmnd[3056]: NO ERR_INVALID_PARAM: Problem > with new class 'LongDnClass' > > > /Neel. > > On Monday 14 July 2014 08:10 PM, Zoran Milinkovic wrote: >> Summary: imm: add support for long DN [#886] >> Review request for Trac Ticket(s): 886 >> Peer Reviewer(s): Neelakanta, Anders >> Pull request to: Zoran >> Affected branch(es): default(4.5) >> Development branch: default(4.5) >> >> -------------------------------- >> Impacted area Impact y/n >> -------------------------------- >> Docs n >> Build system n >> RPM/packaging n >> Configuration files n >> Startup scripts n >> SAF services y >> OpenSAF services n >> Core libraries n >> Samples n >> Tests y >> Other n >> >> >> Comments (indicate scope for each "y" above): >> --------------------------------------------- >> >> changeset 60ba40f3a2b55b564b73630d38bb594ac4eeced7 >> Author: Zoran Milinkovic <[email protected]> >> Date: Mon, 14 Jul 2014 16:29:00 +0200 >> >> imm: add support for long DN to IMM service [#886] >> >> The patch contains a code for the support long DNs in IMM service >> >> changeset 6c8c17209176a70e3d922d5294cf02dd489590bb >> Author: Zoran Milinkovic <[email protected]> >> Date: Mon, 14 Jul 2014 16:30:49 +0200 >> >> imm: add support for long DN to IMM library [#886] >> >> The patch contains a code for the support long DNs in IMM library >> >> changeset 54ee330a6132782883d3df036f99298df9153dad >> Author: Zoran Milinkovic <[email protected]> >> Date: Mon, 14 Jul 2014 16:31:40 +0200 >> >> imm: add support for long DN to IMM tools [#886] >> >> The patch contains a code for the support long DNs in IMM tools >> >> changeset e003b7c7c3e7054811ec237ba48d4562b7105432 >> Author: Zoran Milinkovic <[email protected]> >> Date: Mon, 14 Jul 2014 16:35:03 +0200 >> >> imm: add test cases for long DN [#886] >> >> New test cases have been added to immomtest and immoitest. If >> SA_ENABLE_EXTENDED_NAMES is not set, immomtest and immoitest can use >> --longDn parameter to set SA_ENABLE_EXTENDED_NAMES for testing. >> >> >> Added Files: >> ------------ >> tests/immsv/implementer/test_saImmOiLongDn.c >> tests/immsv/management/test_saImmOmLongDn.c >> >> >> Complete diffstat: >> ------------------ >> osaf/libs/agents/saf/imma/Makefile.am | 4 +- >> osaf/libs/agents/saf/imma/imma_cb.h | 1 + >> osaf/libs/agents/saf/imma/imma_db.c | 3 + >> osaf/libs/agents/saf/imma/imma_init.c | 28 ++++--- >> osaf/libs/agents/saf/imma/imma_oi_api.c | 139 >> ++++++++++++++++++--------------------- >> osaf/libs/agents/saf/imma/imma_om_api.c | 228 >> ++++++++++++++++++++++++++++++++--------------------------------- >> osaf/libs/agents/saf/imma/imma_proc.c | 134 >> ++++++++++++++++++++++++-------------- >> osaf/libs/common/immsv/Makefile.am | 1 + >> osaf/libs/common/immsv/immpbe_dump.cc | 30 +++---- >> osaf/libs/common/immsv/immsv_evt.c | 111 >> ++++++++++++++++++++++--------- >> osaf/libs/common/immsv/include/immsv_api.h | 5 + >> osaf/services/saf/immsv/immd/Makefile.am | 2 +- >> osaf/services/saf/immsv/immd/immd_amf.c | 3 +- >> osaf/services/saf/immsv/immd/immd_evt.c | 3 +- >> osaf/services/saf/immsv/immloadd/Makefile.am | 1 + >> osaf/services/saf/immsv/immloadd/imm_loader.cc | 54 ++++++-------- >> osaf/services/saf/immsv/immnd/ImmModel.cc | 240 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------- >> osaf/services/saf/immsv/immnd/Makefile.am | 2 +- >> osaf/services/saf/immsv/immnd/immnd_amf.c | 3 +- >> osaf/services/saf/immsv/immnd/immnd_evt.c | 36 +++++---- >> osaf/services/saf/immsv/immnd/immnd_proc.c | 6 +- >> osaf/services/saf/immsv/immpbed/Makefile.am | 1 + >> osaf/services/saf/immsv/immpbed/immpbe.cc | 8 +- >> osaf/services/saf/immsv/immpbed/immpbe_daemon.cc | 130 >> ++++++++++++++++++------------------- >> osaf/tools/safimm/immadm/Makefile.am | 1 + >> osaf/tools/safimm/immadm/imm_admin.c | 14 +-- >> osaf/tools/safimm/immcfg/Makefile.am | 1 + >> osaf/tools/safimm/immcfg/imm_cfg.c | 22 +++-- >> osaf/tools/safimm/immcfg/imm_import.cc | 61 +++++++++-------- >> osaf/tools/safimm/immdump/Makefile.am | 1 + >> osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 10 +- >> osaf/tools/safimm/immfind/Makefile.am | 1 + >> osaf/tools/safimm/immfind/imm_find.c | 16 ++-- >> osaf/tools/safimm/immlist/Makefile.am | 1 + >> osaf/tools/safimm/immlist/imm_list.c | 8 +- >> osaf/tools/safimm/src/immutil.c | 92 >> ++++++++++++++++---------- >> tests/immsv/common/immtest.c | 30 ++++++-- >> tests/immsv/implementer/Makefile.am | 1 + >> tests/immsv/implementer/applier.c | 24 ++++-- >> tests/immsv/implementer/test_cleanup.c | 38 ++++++---- >> tests/immsv/implementer/test_saImmOiLongDn.c | 621 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> tests/immsv/management/Makefile.am | 1 + >> tests/immsv/management/test_cleanup.c | 38 ++++++---- >> tests/immsv/management/test_saImmOmLongDn.c | 368 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 44 files changed, 1900 insertions(+), 622 deletions(-) >> >> >> Testing Commands: >> ----------------- >> immomtest 8 >> or >> immomtest --longDn 8 >> >> immoitest 7 >> or >> immoitest --longDn 7 >> >> >> Testing, Expected Results: >> -------------------------- >> All test must pass >> >> >> Conditions of Submission: >> ------------------------- >> Ack from Neelakanta and Anders >> >> >> Arch Built Started Linux distro >> ------------------------------------------- >> mips n n >> mips64 n n >> x86 n n >> x86_64 n n >> powerpc n n >> powerpc64 n n >> >> >> Reviewer Checklist: >> ------------------- >> [Submitters: make sure that your review doesn't trigger any checkmarks!] >> >> >> Your checkin has not passed review because (see checked entries): >> >> ___ Your RR template is generally incomplete; it has too many blank entries >> that need proper data filled in. >> >> ___ You have failed to nominate the proper persons for review and push. >> >> ___ Your patches do not have proper short+long header >> >> ___ You have grammar/spelling in your header that is unacceptable. >> >> ___ You have exceeded a sensible line length in your headers/comments/text. >> >> ___ You have failed to put in a proper Trac Ticket # into your commits. >> >> ___ You have incorrectly put/left internal data in your comments/files >> (i.e. internal bug tracking tool IDs, product names etc) >> >> ___ You have not given any evidence of testing beyond basic build tests. >> Demonstrate some level of runtime or other sanity testing. >> >> ___ You have ^M present in some of your files. These have to be removed. >> >> ___ You have needlessly changed whitespace or added whitespace crimes >> like trailing spaces, or spaces before tabs. >> >> ___ You have mixed real technical changes with whitespace and other >> cosmetic code cleanup changes. These have to be separate commits. >> >> ___ You need to refactor your submission into logical chunks; there is >> too much content into a single commit. >> >> ___ You have extraneous garbage in your review (merge commits etc) >> >> ___ You have giant attachments which should never have been sent; >> Instead you should place your content in a public tree to be pulled. >> >> ___ You have too many commits attached to an e-mail; resend as threaded >> commits, or place in a public tree for a pull. >> >> ___ You have resent this content multiple times without a clear indication >> of what has changed between each re-send. >> >> ___ You have failed to adequately and individually address all of the >> comments and change requests that were proposed in the initial review. >> >> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >> >> ___ Your computer have a badly configured date and time; confusing the >> the threaded patch review. >> >> ___ Your changes affect IPC mechanism, and you don't present any results >> for in-service upgradability test. >> >> ___ Your changes affect user manual and documentation, your patch series >> do not contain the patch that updates the Doxygen manual. >> ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
