Summary:dtm: set IPV6_MULTICAST_IF setsock option on snd/rcv sockets to use
specific interface[#933]
Review request for Trac Ticket(s): #933
Peer Reviewer(s): Neel
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): 4.4 & default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset a36b8a6699b91b0176394460ff290203d048de02
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Thu, 24 Jul 2014 11:04:38 +0530
dtm: set IPV6_MULTICAST_IF setsock option on snd/rcv sockets to use
specific
interface[#933] dtm: set IPV6_MULTICAST_IF setsock option on snd/rcv
sockets
to use specific interface[#933] Currently the dtm discovery udp
receive/sender sockets are NOT bind to a device name which holds
dtmd.conf configured IP address.
The requirement is snd/rcv sockets should use specific interface ,
to achive that :
1) Excludes setting SO_BINDTODEVICE for sender/receiver sockets was
done.
2) multicast/bcast udp sender/receiver sockets join a multicast
group on a specific interface/device name
3) multicast/bcast udp sender/receiver sockets IPV6_MULTICAST_IF set
tp specific interface/device name (Note : This may be redundant will
be cleaned-up in final patch)
4) The patch only addresses the multicast IPv6 udp traffic.
5) If there is any requirement even for the Unicast traffic (
Opensaf Application traffic also) to be routed through the specific
interface which was configured as DTM_NODE_IP (dtmd.conf), we need
to raise a new #Ticket for that. To support that we need should be
demonizes as root user to set SO_BINDTODEVICE and all other Opensaf
service still runs as non- root user as it was.
Complete diffstat:
------------------
osaf/services/infrastructure/dtms/dtm/dtm_node_sockets.c | 60
++++++++++++++++++++++++++++++++++++++++++++++++++++++------
1 files changed, 54 insertions(+), 6 deletions(-)
Testing Commands:
-----------------
use `netstat --inet6 -i` to see dtm discovery udp receive/sender traffic is
using
specific interface.
Testing, Expected Results:
--------------------------
the dtm discovery udp receive/sender traffic should use
specific interface.
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
