Summary: amfd: return admin op when csi assign/remove is over [#372] Review request for Trac Ticket(s): #372 Peer Reviewer(s): Hans F, Hans N, Praveen Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): All Development branch: Default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset fc6ec7e50d5b232bd7255fb68c0916099779f991 Author: Nagendra Kumar<[email protected]> Date: Thu, 24 Jul 2014 19:28:53 +0530 amfd: return admin op when csi assign/remove is over [#372] As of now, amf return admin op except si swap immediately after admin op is invoked. Ideally, amf should first complete csi assignment or csi removal then only amf should return admin op. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/ndproc.cc | 14 ++++++++++++++ osaf/services/saf/amf/amfd/sgproc.cc | 9 +++++++++ osaf/services/saf/amf/amfd/si.cc | 5 ++--- 3 files changed, 25 insertions(+), 3 deletions(-) Testing Commands: ----------------- Take demo appl. 1. Perform lock operation on si and check whether admin op is returning after csi is complete or not. 2. Perform shutdown operation on si and check whether admin op is returning after csi is complete or not. 3. Perform unlock operation on si and check whether admin op is returning after csi is complete or not. 4. Perform lock operaiton on si and make sure csi timeout and su moves into term failed. 5. Perform lock-in, unlock-in, restart admin operation on si. Testing, Expected Results: -------------------------- 1. Admin op return after csi removal with OK. 2. Admin op return after csi removal with OK. 3. Admin op return after csi assignment with OK. 4. Admin op return when su goes into term failed with SA_AIS_ERR_REPAIR_PENDING. 5. Admin op return SA_AIS_ERR_NOT_SUPPORTED immediately. Conditions of Submission: ------------------------- Ack from peer maintainers. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
