Summary: amfd: allow lock on su after issue of shutdown [#582] Review request for Trac Ticket(s): #582 Peer Reviewer(s): Hans F, Hans N, Praveen Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): All. Development branch: Default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset e2b90c7cbfa5595d012d87352cbec50e0eb5e763 Author: Nagendra Kumar<[email protected]> Date: Thu, 31 Jul 2014 19:12:52 +0530 amfd: allow lock on su after issue of shutdown [#582] Shutdown operation was rejected because shitdown operation was going on. Amf should respect lock operation as per Specs. Now, if lock is issued on su when shutdown is going on, then Amf will send response for shutdown first and then start lock operation. Once lock operation is completed, then Amf will respond to imm for lock operation. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 14 +++++++------- osaf/services/saf/amf/amfd/su.cc | 18 ++++++++++++++---- 2 files changed, 21 insertions(+), 11 deletions(-) Testing Commands: ----------------- 1. Perform shutdown and then perform lock. 2. Perform shutdown and then perform unlock. 3. Perform shutdown and then perform lock. 4. Perform shutdown and then perform lock-in. 5. Perform shutdown and then perform unlock-in. 6. Perform shutdown and then perform restart. 7. Perform shutdown on Su1 and lock SU2. Testing, Expected Results: -------------------------- 1. When lock operation comes then shutdown op is responded. After lock operation completes then imm is responded. 2. Get "SG state is not stable" and then succed. 3. Get "Admin operation (2) has no effect on current state (2)". 4. Get "SG state is not stable" and then SU gets terminated. 5. got "Admin operation (4) has no effect on current state (2)". 6. Got "Unsupported admin op for SU: 6". 7. Got "Admin operation is already going on (su'safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1')'" and then Su2 got assignment removed. Conditions of Submission: ------------------------- Ack Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Infragistics Professional Build stunning WinForms apps today! Reboot your WinForms applications with our WinForms controls. Build a bridge from your legacy apps to the future. http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
