Summary: amfd : reply for admin operation on SG after its completion [#293] Review request for Trac Ticket(s): #293 Peer Reviewer(s): AMF contributors Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): ALL Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 70bcf49a0ba0f033f7aa0e95fb3c828a5e19a3f6 Author: [email protected] Date: Fri, 01 Aug 2014 00:13:26 +0530 amfd : reply for admin operation on SG after its completion [#293] SG admin operations on SG are returned without actual completion. Currently AMF replies to IMM for admin operations without checking the actual states of SIs, SUs, SUSIs and sg_fsm. Patch fixes the problem by replying to IMM for the completion of admin operation after Sg becomes stable or if the affected entities are in stable state. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/include/amfd.h | 1 + osaf/services/saf/amf/amfd/include/sg.h | 8 ++++ osaf/services/saf/amf/amfd/ndproc.cc | 20 +++++++++++ osaf/services/saf/amf/amfd/sg.cc | 114 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 2 +- 5 files changed, 143 insertions(+), 2 deletions(-) Testing Commands: ----------------- Tested LOCK,LOCK_IN, SHUTDOWN, UNLOCK and UNLOCK_IN operations on all red models Testing, Expected Results: -------------------------- AMF replied only after completion of admin operations. Conditions of Submission: ------------------------- Ack from any reviewer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
