Hi, I will push this ticket later today. I will push to 4.3, 4.4 and 4.5. Note that this fix will no longer be relevant in 4.5 if #873 is implemented but before that it is relevant. This will prohibit eventual problems if #873 for some reason is postponed to 4.6. The changes for #892 are small so there will be a small task to fix the #873 patches because of this.
Thanks Lennart > -----Original Message----- > From: praveen malviya [mailto:[email protected]] > Sent: den 25 juni 2014 06:55 > To: Lennart Lund > Cc: [email protected]; [email protected] > Subject: Re: [PATCH 1 of 2] ntf: Fix validation of length for SaNameT [#892] > > Ack for both the patches. > Tested with and without patch. > > Thanks, > Praveen > On 24-Jun-14 1:46 PM, Lennart Lund wrote: > > osaf/libs/agents/saf/ntfa/ntfa_api.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > Fix the NTF API to check if SaNameT length >= 256 instead of > 256. > > length must not have a value > 255. > > Check implemented for notifyingObject and notificationObject > > > > diff --git a/osaf/libs/agents/saf/ntfa/ntfa_api.c > > b/osaf/libs/agents/saf/ntfa/ntfa_api.c > > --- a/osaf/libs/agents/saf/ntfa/ntfa_api.c > > +++ b/osaf/libs/agents/saf/ntfa/ntfa_api.c > > @@ -305,7 +305,7 @@ static SaAisErrorT checkHeader(SaNtfNoti > > { > > int i =0; > > > > - if (nh->notificationObject->length > SA_MAX_NAME_LENGTH || nh- > >notifyingObject->length > SA_MAX_NAME_LENGTH) { > > + if (nh->notificationObject->length >= SA_MAX_NAME_LENGTH || > > +nh->notifyingObject->length >= SA_MAX_NAME_LENGTH) { > > TRACE_1("SaNameT length too big"); > > return SA_AIS_ERR_INVALID_PARAM; > > } ------------------------------------------------------------------------------ Infragistics Professional Build stunning WinForms apps today! Reboot your WinForms applications with our WinForms controls. Build a bridge from your legacy apps to the future. http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
