Ack.
I will push this patch.

Thanks,
Praveen

On 04-Aug-14 10:50 AM, Gary Lee wrote:
>   osaf/services/saf/amf/amfd/app.cc |  1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> Ensure app.name.value is null terminated. It seems some code
> assumes SaNameT.value is null terminated, eg. ccbutil_getCcbOpDataByDN()
> in immutil.c.
>
> diff --git a/osaf/services/saf/amf/amfd/app.cc 
> b/osaf/services/saf/amf/amfd/app.cc
> --- a/osaf/services/saf/amf/amfd/app.cc
> +++ b/osaf/services/saf/amf/amfd/app.cc
> @@ -45,6 +45,7 @@ AVD_APP::AVD_APP(const SaNameT* dn) :
>       app_type_list_app_next(NULL),
>       app_type(NULL)
>   {
> +     memset(&name, 0, sizeof(SaNameT));
>       memcpy(name.value, dn->value, dn->length);
>       name.length = dn->length;
>       memset(&saAmfAppType, 0, sizeof(SaNameT));
>

------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to