Ack (not tested). Some minor comments:
* There were a few occurrences of control statements (if, for, while) where the space was missing between the statement and the left parenthesis, e.g.: if( for( while( * sleep() was used instead of osaf_nanosleep() in a couple of places. * Trailing whitespace was added on some lines (tip: use the emacs configuration from the OpenSAF wiki and load the patch file into emacs. The trailing whitespace will be clearly visible in red colour). / Anders Widell On 06/16/2014 03:12 PM, Ingvar Bergstrom wrote: > Summary: smfd: single step procedures only reboot affected nodes > Review request for Trac Ticket(s): 140 > Peer Reviewer(s): Anders Widell > Pull request to: > Affected branch(es): default > Development branch: default > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services y > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > In a single step upgrade where at least one node requires reboot to > install/remove the bundle, smfd will only reboot affetcted nodes. > The behavior is controlled by a new SMF config attribute > smfClusterControllers. > -if not set, no change in behavior i.e. the whole cluster is rebooted. > -if set and at least one controller is not within the list of affected nodes, > only affected nodes are rebooted. > > changeset 0f10743ad4d40778eb568c6f8908bf71e6969d31 > Author: Ingvar Bergstrom <[email protected]> > Date: Mon, 16 Jun 2014 15:00:08 +0200 > > smfd: single step procedures only reboot affected nodes [#140] > > This patch only affect single step procedures where one ore several > nodes > requires reboot. The following behavior is expected depending on the > values > put in config attribute smfClusterControllers: > -If no controllers are defined behavior is unchanged i.e. the whole > cluster > is rebooted. > -If at least one controller is not within the list of affected > nodes,only > affected nodes are rebooted. > > > Complete diffstat: > ------------------ > osaf/services/saf/smfsv/README | 4 + > osaf/services/saf/smfsv/config/smfsv_classes.xml | 7 ++ > osaf/services/saf/smfsv/smfd/SmfCampaign.hh | 1 + > osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc | 77 > ++++++++++++++++++++-------- > osaf/services/saf/smfsv/smfd/SmfUpgradeStep.cc | 351 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------ > osaf/services/saf/smfsv/smfd/SmfUpgradeStep.hh | 11 ++++ > osaf/services/saf/smfsv/smfd/SmfUtils.cc | 79 > +++++++++++++++++++++++++---- > osaf/services/saf/smfsv/smfd/SmfUtils.hh | 8 ++ > osaf/services/saf/smfsv/smfd/smfd_campaign_oi.cc | 114 > ++++++++++++++++++++++++++++++++++++++++-- > osaf/services/saf/smfsv/smfd/smfd_cb.h | 1 + > osaf/services/saf/smfsv/smfd/smfd_smfnd.c | 89 > ++++++++++++++------------------ > osaf/services/saf/smfsv/smfd/smfd_smfnd.h | 8 ++ > 12 files changed, 563 insertions(+), 187 deletions(-) > > > Testing Commands: > ----------------- > > > > Testing, Expected Results: > -------------------------- > > > > Conditions of Submission: > ------------------------- > > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
