Summary: amfd: refactor SI-SI dependency code part 1 [#713] Review request for Trac Ticket(s): 713 Peer Reviewer(s): AMF devs Pull request to: Affected branch(s): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- First attempt at refactoring si_dep.cc from C to C++. There should be no functionality change as nearly all the changes are simple conversion from C to C++ member functions. changeset 932a90a19dd1c11fc391ce21b496a87f10ffa476 Author: Gary Lee <[email protected]> Date: Tue, 19 Aug 2014 14:24:31 +1000 amfd: Change avd_sidep_si_dep_state_set to a member func [#713] changeset 4a8c5d058ba5cfc7aa40b7e830f237a7b066be9f Author: Gary Lee <[email protected]> Date: Tue, 19 Aug 2014 14:24:31 +1000 amfd: Change sidep_is_si_active to a member function [#731] changeset 444759f29ad897e0fef59c481a7c796251814f52 Author: Gary Lee <[email protected]> Date: Tue, 19 Aug 2014 14:24:31 +1000 amfd: change avd_sidep_all_sponsors_active to a member function [#713] changeset 160f82648b2782144152a24a12b7bcb72afeb734 Author: Gary Lee <[email protected]> Date: Tue, 19 Aug 2014 14:24:31 +1000 amfd: change avd_si_unassign to a member function [#713] changeset bed9bd05297ca5e83b111d1509b3367078996ff0 Author: Gary Lee <[email protected]> Date: Tue, 19 Aug 2014 14:24:31 +1000 amfd: change sidep_update_dependents_states to a member function [#713] changeset c17980272b0c041d2b48d3cd325a776ed4823c36 Author: Gary Lee <[email protected]> Date: Tue, 19 Aug 2014 14:24:31 +1000 amfd: change sidep_si_screen_si_dependencies to a member function [#713] changeset a6b079482acf102bf038aa7a73c2530babcc7314 Author: Gary Lee <[email protected]> Date: Tue, 19 Aug 2014 14:24:31 +1000 amfd: change avd_sidep_send_active_to_dependents to a member function [#713] changeset c5fca43ae9125b6f25e267c64b17f2e96a105c05 Author: Gary Lee <[email protected]> Date: Tue, 19 Aug 2014 14:47:33 +1000 amfd: change avd_sidep_sponsors_assignment_states to a member function [#713] changeset 89f61014a419000739fbb1c1f50aa4ae8e7c7846 Author: Gary Lee <[email protected]> Date: Tue, 19 Aug 2014 14:47:33 +1000 amfd: change sidep_unassign_dependent to a member function [#713] changeset 9adde7cb0e69653021e6fd91d4338c80b57e5dd4 Author: Gary Lee <[email protected]> Date: Tue, 19 Aug 2014 14:47:33 +1000 amfd: change sidep_stop_tol_timer to a member function [#713] changeset 75558937a8b7d87876509749ad222ea2e8e101fd Author: Gary Lee <[email protected]> Date: Tue, 19 Aug 2014 14:47:33 +1000 amfd: change rec_already_in_sponsor_list to a member function [#713] changeset ff58de7bb89908f0f4e3f3ca70bd31bfc5e3410b Author: Gary Lee <[email protected]> Date: Tue, 19 Aug 2014 14:47:33 +1000 amfd: change sidep_take_action_on_dependents to a member function [#713] changeset efb0ff14d35da850e14f7bb6819547152d730b92 Author: Gary Lee <[email protected]> Date: Tue, 19 Aug 2014 14:47:33 +1000 amfd: change sidep_update_si_self_dep_state to a member function [#713] changeset ee3f1757fe1f39f8130e4d7c376018e8c5e933c8 Author: Gary Lee <[email protected]> Date: Tue, 19 Aug 2014 14:47:33 +1000 amfd: change take_action() and perform_role_failover() to member funcs [#713] changeset 6887d17d9df74b32a6ed4e13f4c23af15afc128b Author: Gary Lee <[email protected]> Date: Tue, 19 Aug 2014 14:47:33 +1000 amfd: change sidep_sg_red_si_process_assignment to a member func [#713] changeset 8d80fc8078a89820ab6fc280f300f85ff33e6850 Author: Gary Lee <[email protected]> Date: Tue, 19 Aug 2014 14:47:33 +1000 amfd: change sidep_process_ready_to_unassign_depstate to a member func [#713] Complete diffstat: ------------------ osaf/services/saf/amf/amfd/ckpt_dec.cc | 2 +- osaf/services/saf/amf/amfd/include/si.h | 20 +++++ osaf/services/saf/amf/amfd/include/si_dep.h | 12 +-- osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 20 ++-- osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 4 +- osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 6 +- osaf/services/saf/amf/amfd/si_dep.cc | 390 +++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------- 7 files changed, 230 insertions(+), 224 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
