Summary: Fix validation of association objects Review request for Trac Ticket(s): 986 Peer Reviewer(s): AMF devels Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): all Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 4a1e6087308b2ecc404bb0ca6a9593492db812cf Author: Hans Feldt <[email protected]> Date: Fri, 22 Aug 2014 13:50:19 +0200 amfd: validate CSType when creating CtCsType [#986] AMF allows to create a SaAmfCtCsType object although the SaAmfCSType object referred to does not exist. Fix by looking up the SaAmfCSType DN in the SaAmfCSType database. changeset 33fba32c8b78919c77bd4791def8874694f9541d Author: Hans Feldt <[email protected]> Date: Fri, 22 Aug 2014 14:09:05 +0200 amfd: validate CSType when creating SvcTypeCsTypes [#986] AMF allows to create a SaAmfSvcTypeCSTypes object although the SaAmfCSType object referred to does not exist. Fix by looking up the SaAmfCSType DN in the SaAmfCSType database. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/ctcstype.cc | 14 ++++++++++++++ osaf/services/saf/amf/amfd/imm.cc | 7 ++++--- osaf/services/saf/amf/amfd/include/util.h | 1 + osaf/services/saf/amf/amfd/svctypecstypes.cc | 20 ++++++++++++++++++-- osaf/services/saf/amf/amfd/util.cc | 45 +++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 82 insertions(+), 5 deletions(-) Testing Commands: ----------------- Create SaAmfCtCsType and SaAmfSvcTypeCSTypes where the CSType does not exist Testing, Expected Results: -------------------------- Should fail Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
