Hi Neelakanta,

Good point.
I know that leap_env_init is called from saImmOmInitialize and 
saImmOiInitialize, and that's what I relied on when I added the code for long 
DN support.

I got confused from Minh steps how he produced the error, and I thought that he 
exported SA_ENABLE_EXTENDED_NAMES before immcfg, but he only tested if 
SA_ENABLE_EXTENDED_NAMES is exported from immns.conf.
I believed that osaf_extended_name_lend caused the problem, which is called 
before immutil_saImmOmInitialize, and added osaf_extended_name_init.

I sent an email to Minh to try to repeat the test with exported 
SA_ENABLE_EXTENDED_NAMES before immcfg.
I'm waiting for his reply, and then I think that the ticket can be changed to 
invalid.

Thanks for the good review,
Zoran


-----Original Message-----
From: Neelakanta Reddy [mailto:[email protected]] 
Sent: den 2 september 2014 17:28
To: Zoran Milinkovic
Cc: [email protected]
Subject: Re: [PATCH 1 of 1] immtools: fix the use of extended names in immcfg 
[#980]

Hi zoran,

The  osaf_extended_name_init  is called in osaf/libs/core/leap/sysf_def.c

uint32_t leap_env_init(void)
{
         if (leap_env_init_count++ != 0) {
                 return NCSCC_RC_SUCCESS;
         }

         TRACE("INITIALIZING LEAP ENVIRONMENT");

         osaf_extended_name_init();



The leap_env_init is called when ncs_core_agents_startup at imma_startup.

created objects using longdns with immcfg. i did not see any problem(tried with 
latest changeset)

The below fix may not be required.

/Neel.


On Monday 25 August 2014 07:14 PM, Zoran Milinkovic wrote:
>   osaf/tools/safimm/immcfg/imm_cfg.c |  1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> The patch enables using osaf_extended_name_* functions in the correct way 
> before the first saImmOmInitialize() is called.
>
> diff --git a/osaf/tools/safimm/immcfg/imm_cfg.c 
> b/osaf/tools/safimm/immcfg/imm_cfg.c
> --- a/osaf/tools/safimm/immcfg/imm_cfg.c
> +++ b/osaf/tools/safimm/immcfg/imm_cfg.c
> @@ -1539,5 +1539,6 @@ static int imm_operation(int argc, char
>   }
>   
>   int main(int argc, char *argv[]) {
> +     osaf_extended_name_init();
>       return imm_operation(argc, argv);
>   }


------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to