With patch #1041, OpenSAF is compiled on 32-bit linux. Ack from me. Best regards, Zoran
-----Original Message----- From: Zoran Milinkovic Sent: den 3 september 2014 17:02 To: '[email protected]'; [email protected]; [email protected] Cc: [email protected] Subject: RE: [PATCH 1 of 1] build: fixed compilation problems for 32-bit[#997] Hi, I have the same comment as Mathi. Addresses should be printed in hexadecimal format. I compiled default branch with gcc 4.4.7 on 32-bit Ubuntu 12.04 and have next compilation error: make[6]: Entering directory `/media/dev/emilzor/development/opensaf-default-test32bit/osaf/libs/core/mds' CC libmds_la-mds_c_db.lo CC libmds_la-mds_main.lo CC libmds_la-mds_papi.lo CC libmds_la-mds_c_sndrcv.lo CC libmds_la-mds_c_api.lo cc1: warnings being treated as errors mds_c_api.c: In function 'mds_mcm_svc_up': mds_c_api.c:1604: error: format '%lx' expects type 'long unsigned int', but argument 7 has type 'MDS_DEST' mds_c_api.c:1614: error: format '%lx' expects type 'long unsigned int', but argument 6 has type 'MDS_DEST' mds_c_api.c: In function 'mds_mcm_svc_down': mds_c_api.c:2675: error: format '%lx' expects type 'long unsigned int', but argument 7 has type 'MDS_DEST' make[6]: *** [libmds_la-mds_c_api.lo] Error 1 Best regards, Zoran -----Original Message----- From: [email protected] [mailto:[email protected]] Sent: den 3 september 2014 16:25 To: Zoran Milinkovic; [email protected]; [email protected] Cc: [email protected] Subject: [PATCH 1 of 1] build: fixed compilation problems for 32-bit[#997] osaf/libs/core/mds/mds_c_db.c | 4 ++-- osaf/libs/core/mds/mds_main.c | 4 ++-- osaf/services/saf/immsv/immnd/ImmModel.cc | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/osaf/libs/core/mds/mds_c_db.c b/osaf/libs/core/mds/mds_c_db.c --- a/osaf/libs/core/mds/mds_c_db.c +++ b/osaf/libs/core/mds/mds_c_db.c @@ -2349,7 +2349,7 @@ MDS_PROCESS_INFO *mds_process_info_get(M int mds_process_info_add(MDS_PROCESS_INFO *info) { - TRACE_ENTER2("dest:%lx, pid:%d", info->mds_dest, info->pid); + TRACE_ENTER2("dest:%"PRIu64", pid:%d", info->mds_dest, + info->pid); info->patnode.key_info = (uint8_t *)&info->mds_dest; int rc = ncs_patricia_tree_add(&process_info_db, (NCS_PATRICIA_NODE *)&info->patnode); @@ -2358,7 +2358,7 @@ int mds_process_info_add(MDS_PROCESS_INF int mds_process_info_del(MDS_PROCESS_INFO *info) { - TRACE_ENTER2("dest:%lx, pid:%d", info->mds_dest, info->pid); + TRACE_ENTER2("dest:%"PRIu64", pid:%d", info->mds_dest, + info->pid); int rc = ncs_patricia_tree_del(&process_info_db, (NCS_PATRICIA_NODE *)&info->patnode); return rc; diff --git a/osaf/libs/core/mds/mds_main.c b/osaf/libs/core/mds/mds_main.c --- a/osaf/libs/core/mds/mds_main.c +++ b/osaf/libs/core/mds/mds_main.c @@ -149,7 +149,7 @@ static void mds_register_callback(int fd } MDS_DEST mds_dest = ncs_decode_64bit(&p); - TRACE("mds: received %d from %lx, pid %d", type, mds_dest, creds->pid); + TRACE("mds: received %d from %"PRIu64", pid %d", type, mds_dest, +creds->pid); osaf_mutex_lock_ordie(&gl_mds_library_mutex); @@ -165,7 +165,7 @@ static void mds_register_callback(int fd osafassert(rc == NCSCC_RC_SUCCESS); } else { /* this happens in clients that uses both OM and OI */ - TRACE("dest %lx already exist", mds_dest); + TRACE("dest %"PRIu64" already exist", mds_dest); // just update credentials info->uid = creds->uid; info->pid = creds->pid; diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc b/osaf/services/saf/immsv/immnd/ImmModel.cc --- a/osaf/services/saf/immsv/immnd/ImmModel.cc +++ b/osaf/services/saf/immsv/immnd/ImmModel.cc @@ -11927,7 +11927,7 @@ ImmModel::cleanTheBasement(InvocVector& for(ci2=sSearchReqContinuationMap.begin(); ci2!=sSearchReqContinuationMap.end(); ++ci2) { - if(now - ci2->second.mCreateTime >= ci2->second.mTimeout) { + if(now - ci2->second.mCreateTime >= (int)ci2->second.mTimeout) + { TRACE_5("Timeout on Search continuation %llu", ci2->first); searchReqs.push_back(ci2->first); } @@ -11969,13 +11969,13 @@ ImmModel::cleanTheBasement(InvocVector& uint32_t oi_timeout = ((*i3)->mState == IMM_CCB_CRITICAL) ? DEFAULT_TIMEOUT_SEC : max_oi_timeout; if(((*i3)->mWaitStartTime && - (now - (*i3)->mWaitStartTime >= oi_timeout)) || + (now - (*i3)->mWaitStartTime >= (int)oi_timeout)) || ((*i3)->mPbeRestartId)) { if((*i3)->mPbeRestartId) { oi_timeout = 0; TRACE_5("PBE restarted id:%u with ccb:%u in critical", (*i3)->mPbeRestartId, (*i3)->mId); - } else if(now - (*i3)->mWaitStartTime >= max_oi_timeout) { + } else if(now - (*i3)->mWaitStartTime >= + (int)max_oi_timeout) { oi_timeout = 0; TRACE_5("CCB %u timeout while waiting on implementer reply", (*i3)->mId); ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
