Summary: Harden/change MDS cleanup of proces_info
Review request for Trac Ticket(s): 1050
Peer Reviewer(s): Mahesh & Anders B (imma part)
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): 4.5 & default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset e37e7ae582ada8011a3ed06104581b01880399ee
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 10 Sep 2014 11:03:49 +0200
mds: use timeout to delete proc info entries [#1050]
With MDS/TIPC osafamfnd randomly fails to start causing failed opensaf
start. osafimmnd logs the infamous "immnd_evt_proc_imm_init: ... MDS
problem?"
Reason is a random timing variation of the TIPC topology DOWN event.
This
sometimes causes the DOWN event to wrongly delete a newly added
process_info
entry.
The patch consists of two parts: 1) The MDS down event just starts a
timer
in MDS, when the timeout event happens the process_info entry is
deleted.
2) A new explicit disconnect() is added to the MDS API intended to be
used
by by a client (such as IMMA) library when it is about to close down the
whole core library.
changeset ae0c36ba13745d97e27fc28e8356e2c0f2d94dfa
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 10 Sep 2014 11:03:51 +0200
imma: use mds_auth_server_disconnect [#1050]
Complete diffstat:
------------------
osaf/libs/agents/saf/imma/imma.h | 1 +
osaf/libs/agents/saf/imma/imma_init.c | 6 +++++
osaf/libs/agents/saf/imma/imma_mds.c | 7 +++--
osaf/libs/core/mds/include/mds_core.h | 1 -
osaf/libs/core/mds/include/mds_dl_api.h | 1 +
osaf/libs/core/mds/include/mds_dt2c.h | 7 +++--
osaf/libs/core/mds/mds_c_api.c | 43
++++++++++++++++++++++++++++++++---------
osaf/libs/core/mds/mds_dt_common.c | 11 +++++++++-
osaf/libs/core/mds/mds_main.c | 143
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------
9 files changed, 163 insertions(+), 57 deletions(-)
Testing Commands:
-----------------
Continous cluster reboot
Continous opensaf restart
immomtest
special test program that back to back does intialize/finalize
abort program holding handle, process_info in MDS cleaned up after timeout
Testing, Expected Results:
--------------------------
All known test pass
Conditions of Submission:
-------------------------
Ack from reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y ubuntu14.04
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
