Summary: log: Fix problem with creation of lots of .nfsxxx... files Review request for Trac Ticket(s): #1042 Peer Reviewer(s): [email protected] Pull request to: Affected branch(es): 4.4 -> Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset be700bc6fdf5c25a99a219d59f34bd4d899382ab Author: Lennart Lund <[email protected]> Date: Fri, 12 Sep 2014 14:46:46 +0200 log: Fix problem with creation of lots of .nfsxxx... files [#1042] Fix log service fault creation of .nfs file in the log directories. * Always do fdatasync() before closing a file. * Always invalidate the stream file descriptor on close also if failed * Save file descriptors if file thread is busy on close. Close files when available again. * If file open time out but file is opened the fd is not used and must be invalidated (closed) * Correct mutex unlock/lock around file I/O * Create a new filename for current log file even if removal of oldest file fail Complete diffstat: ------------------ osaf/services/saf/logsv/lgs/lgs_file.c | 103 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- osaf/services/saf/logsv/lgs/lgs_file.h | 2 + osaf/services/saf/logsv/lgs/lgs_filehdl.c | 132 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------- osaf/services/saf/logsv/lgs/lgs_filehdl.h | 2 +- osaf/services/saf/logsv/lgs/lgs_stream.c | 69 +++++++++++++++++++++++++++-------------------------- tests/logsv/tet_LogOiOps.c | 21 ++++++++++++++-- 6 files changed, 271 insertions(+), 58 deletions(-) Testing Commands: ----------------- a) # logtest b) For more testing the following can be done: In file lgs_filehdl.c there is an outcommented define RAND_TIMEOUT_TEST. If this define is activated and the log service is rebuilt a delay will be activated randomly causing file I/O operations to time out. Run logtest Testing, Expected Results: -------------------------- a) All testcases shall PASS b) The log service shall not crash. Some testcases may fail but shall only fail on imm command timeout which some testcases cannot handle. In test cases writing log records there will be many TRY_AGAIN messages but the test case shall eventually PASS. Conditions of Submission: ------------------------- Ack by reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce Perforce version control. Predictably reliable. http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
