Right. Ack from me.
/AndesBj Zoran Milinkovic wrote: > The problem is not ignored. > Just after switch statement, there is a check if the iterator points to the > end of list, and handle this situation. > > Regards, > Zoran > > -----Original Message----- > From: Anders Björnerstedt > Sent: den 19 september 2014 09:55 > To: [email protected]; Zoran Milinkovic > Cc: [email protected] > Subject: RE: [devel] [PATCH 1 of 1] imm: check the end ccb iterator before > acessing data for ccb augument [#1100] > > Actually on second thought, I think it would be be better to osafsassert > than to do an if. > With the current patch we silently ignore a problem. > > /AndersBj > > -----Original Message----- > From: Anders Björnerstedt [mailto:[email protected]] > Sent: den 19 september 2014 09:48 > To: [email protected]; Zoran Milinkovic > Cc: [email protected] > Subject: Re: [devel] [PATCH 1 of 1] imm: check the end ccb iterator before > acessing data for ccb augument [#1100] > > Ack from me. > > Not tested. > > /AndersBj > > -----Original Message----- > From: [email protected] [mailto:[email protected]] > Sent: den 19 september 2014 09:54 > To: Anders Björnerstedt; Zoran Milinkovic > Cc: [email protected] > Subject: [PATCH 1 of 1] imm: check the end ccb iterator before acessing data > for ccb augument [#1100] > > osaf/services/saf/immsv/immnd/ImmModel.cc | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > > diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc > b/osaf/services/saf/immsv/immnd/ImmModel.cc > --- a/osaf/services/saf/immsv/immnd/ImmModel.cc > +++ b/osaf/services/saf/immsv/immnd/ImmModel.cc > @@ -5819,14 +5819,18 @@ ImmModel::ccbAugmentInit(immsv_oi_ccb_up > for(omuti=ccb->mMutations.begin();omuti != > ccb->mMutations.end();++omuti) { > if(omuti->second->mContinuationId == rsp->inv) {break;} > } > - obj = omuti->second->mAfterImage; > + if(omuti != ccb->mMutations.end()){ > + obj = omuti->second->mAfterImage; > + } > break; > > case IMM_CCB_MODIFY_OP: > TRACE("Augment CCB in state MODIFY_OP"); > > omuti = ccb->mMutations.find(objectName); > - obj = omuti->second->mAfterImage; > + if(omuti != ccb->mMutations.end()){ > + obj = omuti->second->mAfterImage; > + } > break; > > case IMM_CCB_DELETE_OP: > > ------------------------------------------------------------------------------ > Slashdot TV. Video for Nerds. Stuff that Matters. > http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk > _______________________________________________ > Opensaf-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensaf-devel > ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that Matters. http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
