Summary: imm: fix loading long data in immload and immcfg [#1130] Review request for Trac Ticket(s): 1130 Peer Reviewer(s): Neelakanta, Anders Pull request to: Zoran Affected branch(es): opensaf-4.3.x Development branch: opensaf-4.3.x
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 7630f2349a8340236fd09ef00b1ce74216ce4c9f Author: Zoran Milinkovic <[email protected]> Date: Fri, 03 Oct 2014 02:24:12 +0200 imm: fix loading long data in immload [#1130] DNs and attribute names could be partially loaded due to buffer size in libxml. The patch merges character fragments. changeset 6f4b38e224d2b3ea6e843a641c1ff41754b172c9 Author: Zoran Milinkovic <[email protected]> Date: Fri, 03 Oct 2014 02:24:36 +0200 immtools: fix loading long data in immcfg [#1130] DNs and attribute names could be partially loaded due to buffer size in libxml. The patch merges character fragments. Complete diffstat: ------------------ osaf/services/saf/immsv/immloadd/imm_loader.cc | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------- osaf/tools/safimm/immcfg/imm_import.cc | 52 +++++++++++++++++++++++++++++++++++++++++----------- 2 files changed, 96 insertions(+), 25 deletions(-) Testing Commands: ----------------- Testing, Expected Results: -------------------------- Loading data on IMM startup (immload) and with immcfg should be successful without truncating data. Conditions of Submission: ------------------------- Ack from Neelakanta and Anders Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
