Yes I agree with that. This would be an update to the README clarifying that an OI doing a ccb augmentation should not do "other" things interleaved with ccb augmentation operations.
In addition, an enhancement ticket should be written to fix the problem that after the augmentation is closed, but before the OI returns from its callback, it is no longer being timer monitored by thew imm server. Thus there is a potential risk that an OI that hangs or loops after a ccb augmentation will block that ccb indefinetely. /AndersBj Neelakanta Reddy wrote: > Hi zoran, > > Reviewed and tested the patch. > Ack with following comment. > > comment: > IMM README must be updated > > /Neel. > > On Monday 10 November 2014 06:37 PM, Zoran Milinkovic wrote: > >> Summary: imm: remove CCB timeout when CCB augmentation is closing [#1183] >> Review request for Trac Ticket(s): 1183 >> Peer Reviewer(s): Neelakanta, Anders >> Pull request to: Zoran >> Affected branch(es): opensaf-4.4.x, opensag-4.5.x, default(4.6) >> Development branch: default(4.6) >> >> -------------------------------- >> Impacted area Impact y/n >> -------------------------------- >> Docs n >> Build system n >> RPM/packaging n >> Configuration files n >> Startup scripts n >> SAF services y >> OpenSAF services n >> Core libraries n >> Samples n >> Tests n >> Other n >> >> >> Comments (indicate scope for each "y" above): >> --------------------------------------------- >> >> changeset 8a9ece4f5cf4d3f1268ef12966eb1b901b7d5dea >> Author: Zoran Milinkovic <[email protected]> >> Date: Mon, 10 Nov 2014 14:03:36 +0100 >> >> imm: remove CCB timeout when CCB augmentation is closing [#1183] >> >> When CCB agumentation is closing, CCB timeout is removed. >> >> >> Complete diffstat: >> ------------------ >> osaf/services/saf/immsv/immnd/ImmModel.cc | 9 ++------- >> 1 files changed, 2 insertions(+), 7 deletions(-) >> >> >> Testing Commands: >> ----------------- >> (OI implementer is set to TestAugWrapper class, and CCB is augmented in >> callbacks) >> # immcfg >> >>> immcfg -c TestAugWrapper -a level=99 testAugWrapper=MyTest >>> >>> >> Testing, Expected Results: >> -------------------------- >> CCB should not be aborted after CCB operations (create/modify/delete), when >> CCB is augmented in OI callback. >> >> >> Conditions of Submission: >> ------------------------- >> Ack from Neelakanta and Anders >> >> >> Arch Built Started Linux distro >> ------------------------------------------- >> mips n n >> mips64 n n >> x86 n n >> x86_64 n n >> powerpc n n >> powerpc64 n n >> >> >> Reviewer Checklist: >> ------------------- >> [Submitters: make sure that your review doesn't trigger any checkmarks!] >> >> >> Your checkin has not passed review because (see checked entries): >> >> ___ Your RR template is generally incomplete; it has too many blank entries >> that need proper data filled in. >> >> ___ You have failed to nominate the proper persons for review and push. >> >> ___ Your patches do not have proper short+long header >> >> ___ You have grammar/spelling in your header that is unacceptable. >> >> ___ You have exceeded a sensible line length in your headers/comments/text. >> >> ___ You have failed to put in a proper Trac Ticket # into your commits. >> >> ___ You have incorrectly put/left internal data in your comments/files >> (i.e. internal bug tracking tool IDs, product names etc) >> >> ___ You have not given any evidence of testing beyond basic build tests. >> Demonstrate some level of runtime or other sanity testing. >> >> ___ You have ^M present in some of your files. These have to be removed. >> >> ___ You have needlessly changed whitespace or added whitespace crimes >> like trailing spaces, or spaces before tabs. >> >> ___ You have mixed real technical changes with whitespace and other >> cosmetic code cleanup changes. These have to be separate commits. >> >> ___ You need to refactor your submission into logical chunks; there is >> too much content into a single commit. >> >> ___ You have extraneous garbage in your review (merge commits etc) >> >> ___ You have giant attachments which should never have been sent; >> Instead you should place your content in a public tree to be pulled. >> >> ___ You have too many commits attached to an e-mail; resend as threaded >> commits, or place in a public tree for a pull. >> >> ___ You have resent this content multiple times without a clear indication >> of what has changed between each re-send. >> >> ___ You have failed to adequately and individually address all of the >> comments and change requests that were proposed in the initial review. >> >> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >> >> ___ Your computer have a badly configured date and time; confusing the >> the threaded patch review. >> >> ___ Your changes affect IPC mechanism, and you don't present any results >> for in-service upgradability test. >> >> ___ Your changes affect user manual and documentation, your patch series >> do not contain the patch that updates the Doxygen manual. >> >> > > > ------------------------------------------------------------------------------ > Comprehensive Server Monitoring with Site24x7. > Monitor 10 servers for $9/Month. > Get alerted through email, SMS, voice calls or mobile push notifications. > Take corrective actions from your mobile device. > http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.clktrk > _______________________________________________ > Opensaf-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensaf-devel > ------------------------------------------------------------------------------ Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
