Summary: ntf/safntf: print lengthAdditionalText with ntfsubscribe -v [#1215]
Review request for Trac Ticket(s): #1215
Peer Reviewer(s): Minh
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): All
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other y
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset e97d2436405183d168b8f775cee1147913937f17
Author: praveen.malv...@oracle.com
Date: Thu, 04 Dec 2014 15:31:16 +0530
ntf/safntf: print lengthAdditionalText with ntfsubscribe -v [#1215]
Complete diffstat:
------------------
osaf/tools/safntf/src/ntfclient.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
Testing Commands:
-----------------
1)ntfsubscribe -v in one terminal.
2)ntfsend in another terminal.
Testing, Expected Results:
--------------------------
Notification will print length of additional text:
=== Dec 4 15:25:36 - Alarm ===
notificationID = 85
subscriptionId = 1
eventType = SA_NTF_ALARM_COMMUNICATION
notificationObject.length = 27
notificationObject = "default notification object"
notifyingObject.length = 24
notifyingObject = "default notifying object"
notificationClassId = 193.0.0 (0x0)
eventTime = 1417686936208315000 (Thu Dec 04 15:25:36 IST 2014)
lengthAdditionalText = 24
additionalText = "default additional text"
probableCause = SA_NTF_BANDWIDTH_REDUCED
perceivedSeverity = SA_NTF_SEVERITY_WARNING
Conditions of Submission:
-------------------------
Ack from Minh.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
