Summary: Fix memory corruption in PLMS
Review request for Trac Ticket(s): 1244
Peer Reviewer(s): Mathi
Pull request to: Mathi
Affected branch(es): default, 4.5
Development branch:
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset f9de25b1b629ca7d6d67fe9743fb0266fcebe0f4
Author: Alex Jones <ajo...@genband.com>
Date: Thu, 22 Jan 2015 16:40:29 -0500
plm: fix memory corruption in plms [#1244]
Symptoms of the problem include PLMS crashing, and the node resetting
because of the crash.
Valgrind shows memory corruption in the plms code. A double free, and
some
uninitialized reads.
Solution for the double free is...don't double free! For the
uninitialized
read the malloc'd string did not take into account the NULL terminator,
and
functions later on (strchr) depend on a NULL terminator being there.
Complete diffstat:
------------------
osaf/services/saf/plmsv/plms/hpi_intf/plms_epath_util.c | 2 +-
osaf/services/saf/plmsv/plms/plms_adm_fsm.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
Testing Commands:
-----------------
1) PLM admin reset an HE that does not have an EE associated with it.
Testing, Expected Results:
--------------------------
1) PLMs should not reset, and valgrind should show no errors.
Conditions of Submission:
-------------------------
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
