Summary: imm: exit the pbe when the verification of class returns TRY_AGAIN
[#1245]
Review request for Trac Ticket(s): 1245
Peer Reviewer(s): AndersBj
Affected branch(es): 4.4.x, 4.5.x, default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset c2465073c5830378a548b08504cac06917f46886
Author: Neelakanta Reddy
Date: Fri, 23 Jan 2015 18:28:47 +0530
imm: exit the pbe when the verification of class returns TRY_AGAIN
[#1245]
when IMMND is down TRY_AGAIN is returned for classdescripton. with this
error imm.db will be Renamed form imm.db to imm.db.failed_immdump. when
the
node reboots and comes up node will come up with default imm.xml
instead of
PBE.
The solution is to exit immpbed when classdescripton returns
TRY_AGAIN.Because, cl_node->isPbe is set only when implementer is set.
Implementer is set only when verification of classes is success when
the PBE
is re-attached.
Complete diffstat:
------------------
osaf/libs/common/immsv/immpbe_dump.cc | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
Testing Commands:
-----------------
Tested by putting sleep of 1 second in verifyClassPBE.
Killing IMMD.
Testing, Expected Results:
--------------------------
with this patch the imm.db must not move imm.db.failed_immdump.
When TRY_AGAIN is returned for classDescription osafpbed must exit.
The only time classDescription returns TRY_AGAIN is when IMMND is down.
Conditions of Submission:
-------------------------
Ack from AndersBj
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
