Summary: imm: Return TRY_AGAIN for CcbApply when fevs_replies_pending greater 
than or equal to IMMSV_DEFAULT_FEVS_MAX_PENDING [#1250] 
Review request for Trac Ticket(s): 1250
Peer Reviewer(s): AndersBj
Affected branch(es): 4.4.x, 4.5.x, default
Development branch: 

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------

changeset dab1605aa638de6f40c469e2a38a9dd02e41cd1a
Author: Neelakanta Reddy
Date:   Thu, 29 Jan 2015 11:15:24 +0530

        imm: Return TRY_AGAIN for CcbApply when fevs_replies_pending greater 
than or
        equal to IMMSV_DEFAULT_FEVS_MAX_PENDING [#1250]

        If the fevs_replies_pending is greater than or equal to
        IMMSV_DEFAULT_FEVS_MAX_PENDING, then TRY_AGAIN is returned from
        immnd_evt_proc_fevs_forward.For saImmOmCcbApply, TRY_AGAIN is converted 
to
        ERR_FAILED_OPERATION.

        Since, the CCB is not yet applied to IMMND, but ERR_FAILED_OPERATION is
        returned. If the IMMSV_DEFAULT_FEVS_MAX_PENDING is checked at
        immnd_fevs_local_checks then ERR_NO_RESOURCES will be returned which 
inturn
        is converted to TRY_AGAIN in CcbApply API.


Complete diffstat:
------------------
 osaf/services/saf/immsv/immnd/immnd_evt.c |  10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)


Testing Commands:
-----------------
Call CcbApply API when  fevs_replies_pending is greater than or equal to 
IMMSV_DEFAULT_FEVS_MAX_PENDING

Testing, Expected Results:
--------------------------
with this patch TRY_AGAIN must be returned.

Conditions of Submission:
-------------------------
Ack from AndersBj

Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to