Summary: smf: defects detected by Coverity tool fixed [#1154] Review request for Trac Ticket(s): #1154 Peer Reviewer(s): Ingvar B, Bertil E Pull request to: Ingvar B Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- smf: defects detected by Coverity tool fixed [#1154] changeset c8f8fa3a00c16bc0935dc39119404dc7cb98bfde Author: Robert Apanowicz <[email protected]> Date: Mon, 16 Feb 2015 12:11:53 +0100 smf: defects detected by Coverity tool fixed [#1154] All SMF defects detected by Coverity tool fixed. Complete diffstat: ------------------ osaf/libs/agents/saf/smfa/smfa_utils.c | 4 +++- osaf/libs/common/smfsv/smfsv_evt.c | 6 +++--- osaf/services/saf/smfsv/smfd/SmfCallback.cc | 1 - osaf/services/saf/smfsv/smfd/SmfCampState.cc | 1 - osaf/services/saf/smfsv/smfd/SmfCampaign.cc | 1 - osaf/services/saf/smfsv/smfd/SmfCampaignXmlParser.cc | 6 ++++-- osaf/services/saf/smfsv/smfd/SmfProcedureThread.cc | 3 ++- osaf/services/saf/smfsv/smfd/SmfStepState.cc | 3 --- osaf/services/saf/smfsv/smfd/SmfStepTypes.cc | 1 - osaf/services/saf/smfsv/smfd/SmfUpgradeMethod.cc | 1 - osaf/services/saf/smfsv/smfd/smfd_amf.c | 1 - osaf/services/saf/smfsv/smfd/smfd_campaign_oi.cc | 3 --- osaf/services/saf/smfsv/smfd/smfd_evt.c | 7 ++++--- osaf/services/saf/smfsv/smfd/smfd_main.c | 3 ++- osaf/services/saf/smfsv/smfd/smfd_mds.c | 2 +- osaf/services/saf/smfsv/smfd/smfd_smfnd.c | 8 ++++---- osaf/services/saf/smfsv/smfnd/Makefile.am | 3 +-- osaf/services/saf/smfsv/smfnd/smfnd_evt.c | 1 - osaf/services/saf/smfsv/smfnd/smfnd_mds.c | 3 +-- 19 files changed, 25 insertions(+), 33 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
