On 12-Mar-15 5:54 PM, Hans Nordebäck wrote:
> ok, but it should be an enum, not a define./Thanks Hans
>
I will make some internal enum
typedef enum {
SA_AMF_NTFID_NG_ADMIN_STATE = 0x072
} SaAmfExtraNotificationMinorIdTThanks Praveen > On 03/12/2015 01:17 PM, praveen malviya wrote: >> >> >> On 12-Mar-15 5:38 PM, Hans Nordebäck wrote: >>> Ack, code review only. Question, why is SA_AMF_NTFID_NG_ADMIN_STATE >>> not added to SaAmfNotificationMinorIdT enum? /Thanks HansN >>> >> Since it is not present in spec/saAmf.h, I kept it internal to AMF. I >> will update it in PR doc. >> >> >> Thanks, >> Praveen >>> -----Original Message----- >>> From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com] >>> Sent: den 2 mars 2015 14:35 >>> To: Hans Nordebäck; nagendr...@oracle.com; Bertil Engelholm; >>> mathi.naic...@oracle.com >>> Cc: opensaf-devel@lists.sourceforge.net >>> Subject: [PATCH 6 of 7] amfd: send state change notification for >>> saAmfNGAdminState [#1235] >>> >>> osaf/services/saf/amf/amfd/include/ntf.h | 2 ++ >>> osaf/services/saf/amf/amfd/nodegroup.cc | 3 +++ >>> 2 files changed, 5 insertions(+), 0 deletions(-) >>> >>> >>> Patch sends state change notification for saAmfNGAdminState with >>> minorId (0x72) for three admin state values: >>> SA_AMF_ADMIN_UNLOCKED =1, >>> SA_AMF_ADMIN_LOCKED = 2, >>> SA_AMF_ADMIN_SHUTTING_DOWN = 4 >>> >>> diff --git a/osaf/services/saf/amf/amfd/include/ntf.h >>> b/osaf/services/saf/amf/amfd/include/ntf.h >>> --- a/osaf/services/saf/amf/amfd/include/ntf.h >>> +++ b/osaf/services/saf/amf/amfd/include/ntf.h >>> @@ -39,6 +39,8 @@ >>> #define OLD_STATE_NA 0 >>> #define NEW_STATE_NA 0 >>> >>> +/*For nodegroup admin state notification*/ #define >>> +SA_AMF_NTFID_NG_ADMIN_STATE 0x072 >>> /* Alarms */ >>> void avd_send_comp_inst_failed_alarm(const SaNameT *comp_name, >>> const SaNameT *node_name); void >>> avd_send_comp_clean_failed_alarm(const SaNameT *comp_name, const >>> SaNameT *node_name); diff --git >>> a/osaf/services/saf/amf/amfd/nodegroup.cc >>> b/osaf/services/saf/amf/amfd/nodegroup.cc >>> --- a/osaf/services/saf/amf/amfd/nodegroup.cc >>> +++ b/osaf/services/saf/amf/amfd/nodegroup.cc >>> @@ -565,6 +565,9 @@ void avd_ng_admin_state_set(AVD_AMF_NG* >>> const_cast<SaImmAttrNameT>("saAmfNGAdminState"), >>> SA_IMM_ATTR_SAUINT32T, &ng->saAmfNGAdminState); >>> m_AVSV_SEND_CKPT_UPDT_ASYNC_UPDT(avd_cb, ng, >>> AVSV_CKPT_NG_ADMIN_STATE); >>> + avd_send_admin_state_chg_ntf(&ng->name, >>> + (SaAmfNotificationMinorIdT)SA_AMF_NTFID_NG_ADMIN_STATE, >>> + old_state, ng->saAmfNGAdminState); >>> } >>> /** >>> * @brief Verify if Node is stable for admin operation on >>> Nodegroup etc. >>> > > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
