Summary: single step uppgrade forAddRemove, with rebootAffectedNodes enabled,
reboot nodes properly
Review request for Trac Ticket(s): 1314
Peer Reviewer(s): Rafael
Pull request to:
Affected branch(es): 4.5 4.6 default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
smfd: when rebootAffectedNodes is enabled smfd now also take the bundle
plmExecEnv spec
in account when rebooting nodes in singleStep/forAddRemove procedures.
The patch have been changed since last review request. Now the CLM nodeId is
read just in time when needed in
the campaign execution, not in smfd csiSet callback as before. Since CLM does
not set nodeId runtime attribute
until CLM node have join the cluster, read it in smfd csiSet code was not a
good solution.
changeset 43f09ce3ed047b5d0beed4adf1fc5aa504a9b364
Author: Ingvar Bergstrom <ingvar.bergst...@ericsson.com>
Date: Tue, 28 Apr 2015 12:39:07 +0200
smfd: single step uppgrade forAddRemove, with rebootAffectedNodes
enabled,
reboot nodes properly [#1314]
When rebootAffectedNodes is enabled and sw bundles list it's own
plmExecEnv
nodes for specific sw bundles, the specified nodes are rebooted.
Complete diffstat:
------------------
osaf/services/saf/smfsv/smfd/SmfUpgradeStep.cc | 191
+++++++++++++++++++++++++++++++++++++++++++++++++++++++------------
osaf/services/saf/smfsv/smfd/SmfUpgradeStep.hh | 14 ++++
osaf/services/saf/smfsv/smfd/smfd_campaign_oi.cc | 79
+--------------------------
3 files changed, 176 insertions(+), 108 deletions(-)
Testing Commands:
-----------------
Set rebootAffectedNodes=1
Run a single step/forAddRemove procedure which install software bundle(s)
requiring reboot to install according to a plmExecEnv list,
Testing, Expected Results:
--------------------------
Check the affected nodes are rebooted. Affected nodes are the nodes where the
procedure
will install any bundle. If any bundle in the procedure need reboot all
affected nodes will be rebooted.
Check the bundles are installed on nodes expected.
-For bundles with plmExecEnv list, on the listed nodes.
-For bundles without plmExecEnv list, on nodes listed in actedOn list.
Conditions of Submission:
-------------------------
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
