Summary: osaf: Fix GCC 5.1.0 compiler warning v2 [#1340]
Review request for Trac Ticket(s): 1340
Peer Reviewer(s): Nagu/Praveen (AMF), Mathi (PLM), Mahesh (MDS)
Pull request to:
Affected branch(es): opensaf-4.5.x, opensaf-4.6.x, default(4.7)
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
v2: Fix plm patch so that it works with newer versions of OpenHPI.
changeset 88f1d61cf53ff6d61bcb0e26e0ec3be5643843d7
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Wed, 29 Apr 2015 14:26:30 +0200
amf: Fix GCC 5.1.0 compiler warning [#1340]
The following warning was fixed by replacing the case statement with an
if
statement:
susm.cc: In function 'uint32_t avnd_evt_avd_su_pres_evh(AVND_CB*,
AVND_EVT*)': susm.cc:1237:26: error: switch condition has type bool
[-Werror
=switch-bool] switch (info->term_state) { ^
changeset 816462630c82e4c2d09204413e808126240e6bba
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Wed, 29 Apr 2015 14:26:30 +0200
mds: Fix GCC 5.1.0 compiler warning [#1340]
The following warning was fixed:
mds_dt_tipc.c: In function 'mdtm_tipc_init': mds_dt_tipc.c:245:28:
error:
comparison of constant '2' with boolean expression is always false
[-Werror
=bool-compare] if (mds_use_network_order == NCSCC_RC_FAILURE) { ^
changeset e7e58247cb16cacaa07b12f1a986abb93a030def
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Wed, 29 Apr 2015 14:28:29 +0200
plm: Fix GCC 5.1.0 compiler warning [#1340]
The following warning was fixed:
plms_hsm.c: In function 'hsm_discover_and_dispatch': plms_hsm.c:685:20:
error: unused variable 'my_entity_path' [-Werror=unused-variable]
SaHpiEntityPathT my_entity_path; ^ plms_hsm.c:684:20: error: unused
variable
'hpirc' [-Werror=unused-variable] SaErrorT hpirc = SA_OK; ^
Complete diffstat:
------------------
osaf/libs/core/mds/mds_dt_tipc.c | 14 ++++++++++----
osaf/services/saf/amf/amfnd/susm.cc | 12 ++++--------
osaf/services/saf/plmsv/plms/hpi_intf/plms_hsm.c | 2 ++
3 files changed, 16 insertions(+), 12 deletions(-)
Testing Commands:
-----------------
Build OpenSAF with GCC version 5.1.0 or later.
Testing, Expected Results:
--------------------------
Build should be successful.
Conditions of Submission:
-------------------------
Ack from reviewers.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
