Summary: amfd: ignore locked-in node during lock, shutdown and unlock op on ng [#1356] Review request for Trac Ticket(s): #1356 Peer Reviewer(s): Hans. Nagendra Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): Default and 4.6 Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 293ef9e29b5a4bebd61e1bd9805d42d10bb31f72 Author: praveen.malv...@oracle.com Date: Thu, 30 Apr 2015 12:27:45 +0530 amfd: ignore locked-in node during lock, shutdown and unlock op on ng [#1356] If a node is in lock-in state and lock, shutdown or unlock are initiated on any of its nodegroup then there are two problems: 1)During lock and shutdown operation on ng, locked-in admin state of node is changed to locked. 2)During unlock operation on ng, locked-in admin state of node is changed to unlocked. In both the above cases locked-in state of node should remain intact. Patch ensures that a locked-in node remains untouched during lock, shutdown and unlock operation on any nodegroup of node. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/nodegroup.cc | 18 ++++++++++++++++-- osaf/services/saf/amf/amfd/sgproc.cc | 2 ++ 2 files changed, 18 insertions(+), 2 deletions(-) Testing Commands: ----------------- Perfromed lock,shutdwon and unlock operation on ng by keeping one of nodes of nodegroup in locked-in admin state. Testing, Expected Results: -------------------------- Locked-in state of the node remains unaffected during operations on nodegroup Conditions of Submission: ------------------------- Ack from any reviewer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel