Summary: ntftools: ntfread and ntfsubscribe do not check invalid options [#1355]
Review request for Trac Ticket(s): #1355
Peer Reviewer(s): praveen.malv...@oracle.com, minh.c...@dektech.com.au,
lennart.l...@ericsson.com
Pull request to: lennart.l...@ericsson.com
Affected branch(es): 4.5, 4.6, default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset 9982d7c77ad9a1ca265a31d99af0354fafd626a8
Author: Vu Minh Nguyen <vu.m.nguyu...@dektech.com.au>
Date: Tue, 05 May 2015 05:14:44 +0100
ntftool: ntfread and ntfsubscribe do not check invalid options [#1355]
ntfread/ntfsubscribe do not check invalid options.
Add code to show invalid options to user.
Complete diffstat:
------------------
osaf/tools/safntf/ntfread/ntfread.c | 7 +++++++
osaf/tools/safntf/ntfsubscribe/ntfsubscribe.c | 13 ++++++++++++-
2 files changed, 19 insertions(+), 1 deletions(-)
Testing Commands:
-----------------
ntfread abc def
ntfsubscribe abc def
Testing, Expected Results:
--------------------------
# ntfread abc def
Invalid non-option:
abc
def
Try 'ntfread -h' for more information.
#
# ntfsubscribe abc def
Invalid non-option:
abc
def
Try 'ntfsubscribe -h' for more information.
Conditions of Submission:
-------------------------
Ack from peer reviewers.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
