On 2015-06-01 15:24, Mathivanan Naickan Palanivelu wrote: > Hi, > >> I would also suggest removing the "amf-" command since we could have >> everything under the "sam" >> umbrella. > > Which "amf-" are you referring to here? Are you talking about naming of the > amf-comptype, amf-cstype, etc?
The ones in tools/amf directory, they should not be needed. Use case covered by sam. Thanks, Hans > > Thanks, > Mathi. > > ----- [email protected] wrote: > >> On 2015-05-28 15:07, Johan Mårtensson O wrote: >>> Hi, >>> >>> Good comments, I think you're right. Comments inline below. >>> >>> / Johan >>> >>> -----Original Message----- >>> From: Hans Feldt >>> Sent: den 27 maj 2015 09:23 >>> To: [email protected]; Johan Mårtensson O >>> Subject: [tools][sam] way forward? >>> >>> Hi, >>> >>> I can see some changesets pushed to the tools repo targeting the >> "sam" tool. Looking at the tool now (half year later after I wrote >> it), it still very much looks like a hack/prototype... >>> >>> I think the single file approach has come to and end. From a python >> coding point it is a mess. >>> flake8 checks are bad. No use of object orientation. Standard >> "python setup.py install" needs to work. >>> Johan: This would definitely be a good improvement and it would make >> it easier/less hacky to add deploy sam in existing systems. >>> >>> immom still in the tree etc. etc. >>> Johan: I noticed this too. One of my changes in the devel branch >> changed the imports to use the proper immom from OpenSAF instead but I >> didn't dare to remove immom from the sam repo. >> >> removed in 2078363f79906ccba83d5f52e9ba91fe6f591c2c >> >>> >>> I would also suggest removing the "amf-" command since we could have >> everything under the "sam" >>> umbrella. >>> Johan: Yes, I agree. It's a bit strange to keep them as separate >> tools next to sam. >> >> Actually just realized that you have done some double work that I had >> already done. I had considered >> the import/creation of comptypes and friends to be something done once >> in the lifetime of a cluster >> lifetime. That justified the need to a specific tool for that. Thus I >> saw no point in adding it to >> the sam tool itself. >> >> OCF import is implemented in the ocf-import-ra script. The problem >> with that is that uses the >> "amf-comptype create" command. >> >> I still think this is a good idea and would contribute to keep the sam >> tool small(er) >> >> What do you think? >> >>> >>> So how do we clean this up to become useful? >>> Johan: With the new commands I've added the sam file has grown and I >> think it would be good to split it into a separate file with AMF >> utility methods and keep the cmd_* functions still in sam. Does this >> make sense? >>> >>> Thanks, >>> Hans >>> >> >> >> ------------------------------------------------------------------------------ >> _______________________________________________ >> Opensaf-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/opensaf-devel > > ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
