Summary: amfd: Convert AMF structs to classes Review request for Trac Ticket(s): [#1142] Peer Reviewer(s): Nagu, Praveen, Gary Pull request to: Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset c9191d0ad3b0448a19ee6b720d588c68dc1c776b Author: Hans Nordeback <[email protected]> Date: Fri, 31 Jul 2015 13:37:37 +0200 amfd: Make AVD_COMP a class [#1142] changeset 0a7b357543d3c47d49823f154c01aabda678c96d Author: Hans Nordeback <[email protected]> Date: Fri, 31 Jul 2015 13:37:37 +0200 amfd: Make AVD_CTCS_TYPE a class [#1142] changeset 8fb4348e6c763a25b494220b3250a49f3eb68cf2 Author: Hans Nordeback <[email protected]> Date: Fri, 31 Jul 2015 13:37:37 +0200 amfd: Make AVD_COMP_TYPE a class [#1142] changeset e06e775176f4bb575c7337fda616dd0dff47ca19 Author: Hans Nordeback <[email protected]> Date: Fri, 31 Jul 2015 13:37:37 +0200 amfd: Make AVD_CS_TYPE a class [#1142] changeset 9888d21f690c20d24d8d48b76deadd79c5fd97c3 Author: Hans Nordeback <[email protected]> Date: Fri, 31 Jul 2015 13:37:37 +0200 amfd: Make AVD_CSI a class [#1142] changeset 440c0318c06f19f0a6917858141f3b12eb0ce812 Author: Hans Nordeback <[email protected]> Date: Fri, 31 Jul 2015 13:37:37 +0200 amfd: Make AVD_AVND a class [#1142] Complete diffstat: ------------------ osaf/services/saf/amf/amfd/comp.cc | 47 ++++++--- osaf/services/saf/amf/amfd/comptype.cc | 14 ++- osaf/services/saf/amf/amfd/csi.cc | 32 +++++- osaf/services/saf/amf/amfd/cstype.cc | 28 +++-- osaf/services/saf/amf/amfd/ctcstype.cc | 9 +- osaf/services/saf/amf/amfd/include/cb.h | 6 +- osaf/services/saf/amf/amfd/include/comp.h | 200 +++++++++++++++++++++++------------------- osaf/services/saf/amf/amfd/include/csi.h | 80 ++++++++++------ osaf/services/saf/amf/amfd/include/msg.h | 32 +++--- osaf/services/saf/amf/amfd/include/node.h | 102 +++++++++++---------- osaf/services/saf/amf/amfd/include/pg.h | 8 +- osaf/services/saf/amf/amfd/include/sg.h | 12 +- osaf/services/saf/amf/amfd/include/si.h | 10 +- osaf/services/saf/amf/amfd/include/su.h | 10 +- osaf/services/saf/amf/amfd/include/util.h | 40 ++++---- osaf/services/saf/amf/amfd/node.cc | 58 ++++++++---- osaf/services/saf/amf/amfd/si.cc | 8 +- osaf/services/saf/amf/amfd/su.cc | 6 +- 18 files changed, 414 insertions(+), 288 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
