Summary: pyosaf: (updated) Add decorated versions of the raw SAF functions (for IMM OM) [#1434] Review request for Trac Ticket(s): #1434 Peer Reviewer(s): [email protected], [email protected], [email protected], [email protected] Pull request to: [email protected] Affected branch(es): 4.7.x Development branch: opensaf-staging
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests n Other y Comments (indicate scope for each "y" above): --------------------------------------------- Updated version to correct according to comments from Srikanth. changeset 6065eb7faab475d0181f52c31dc3a0f74c8bb39a Author: Johan Mårtensson <[email protected]> Date: Mon, 20 Jul 2015 13:42:36 +0200 pyosaf: Add decorated versions of each saImmOm* function in immom Add a decorate function that takes a raw SAF function call and adds a retry- loop and raising of an exception if encounters a fault. Use this decorator to add decorated versions of each function in saImmOm* to the immom module. There is no registered ticket as sourceforge is down. changeset 5b19cb23c582c275d3ed5e59b03671861a541164 Author: Johan Mårtensson <[email protected]> Date: Mon, 20 Jul 2015 13:51:32 +0200 pyosaf: Use decorated saImmOm functions in immom/__init__.py The immom module contains decorated versions of the raw saImmOm functions that do automatic retries and raises exceptions on faults. Use them in immom/__init__.py. changeset a2eae2aaf0af8ff0b8914a3fae32bd9d43931bd8 Author: Johan Mårtensson <[email protected]> Date: Mon, 20 Jul 2015 14:08:13 +0200 pyosaf: Make Ccb, InstanceIterator and SearchIterator use decorated SAF functions Change Ccb, InstanceIterator and SearchIterator use decorated versions instead of the raw SAF functions. This aligns them so that all calls use the same retry loop. Previously only some functions used a retry loop. No other functional changes are done. changeset 57359b7bff6fc879ed0e4d102bfef8ab796d75d1 Author: Johan Mårtensson <[email protected]> Date: Mon, 20 Jul 2015 14:59:45 +0200 pyosaf: SafException is moved to pyosaf.utils, remove un-used pyosaf.utils.immom.common SafException is moved to pyosaf.utils so that it can be shared between immom and immoi when it is added. Remove pyosaf.utils.immom.common only contains the old definition of SafException so remove it. changeset a799bd587c703fe8a0bc379db1d46ea527d255d2 Author: Johan Mårtensson <[email protected]> Date: Wed, 05 Aug 2015 11:27:04 +0200 pyosaf: Change to use 60 retries to align with previous behavior [#1434] The previous behavior, before changing callers to use decorated functions, was to use 60 retries and this was mistakenly changed in a previous patch. Removed Files: -------------- python/pyosaf/utils/immom/common.py Complete diffstat: ------------------ python/pyosaf/utils/__init__.py | 56 +++++++++++++++++++++++++++++++++++++++++++++++ python/pyosaf/utils/immom/__init__.py | 144 ++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------- python/pyosaf/utils/immom/ccb.py | 124 +++++++++++++++++++-------------------------------------------------------------------------------------- python/pyosaf/utils/immom/common.py | 32 --------------------------- python/pyosaf/utils/immom/iterator.py | 51 +++++++++++++++++------------------------- 5 files changed, 157 insertions(+), 250 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
