Summary: AMFND: Comp receives QUIESCED csi when it has not received ACTIVE csi [#1386] V4 Review request for Trac Ticket(s): 1386 Peer Reviewer(s): Hans N, Nagu, Praveen, Gary Pull request to: Affected branch(es): 4.5, 4.6, default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- In patch version 3, it marks suspending_assignment flag of all unassigned csi(s) (not as only one csi as in version 2) since the flag suspending_assignment is affected to determination of su_si completion where all csi(s) should be taken into account Patch version 4 has fixed a problem of version 3 where the unassigned component has being received remove csi callback. When comp is marked assigned, all other csi(s) will set to ASSIGNED state only if these csi(s) are not marked to suspend assignment changeset aa6280b43b3f1afd47bd02a9aaa3179b74af57d2 Author: Minh Hon Chau <[email protected]> Date: Thu, 06 Aug 2015 14:40:57 +1000 AMFND: Comp receives QUIESCED csi when it has not received ACTIVE csi [#1386] V4 If su-si active assignment is on-going, some csi(s) may get assigned but other csi(s) could be still in unassigned state. At this point, assigning component issues saAmfErrorReport(COMPONENT_FAILOVER), AMFND receives QUIESCED assignment from AMFD. The unassigned yet component also receives the quiesced csi callback that should not happen Adding new flag suspending_assignment, which indicates the unassigned csi(s) will not involve in QUIESCED/QUIESCING assignment loop. Once su-si QUIESCED/QUIESCING assignment is done, this flag reset to false. Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/comp.cc | 47 ++++++++++++++++++++++++++++++++----- osaf/services/saf/amf/amfnd/include/avnd_comp.h | 9 +++++++ osaf/services/saf/amf/amfnd/sidb.cc | 2 +- osaf/services/saf/amf/amfnd/susm.cc | 55 +++++++++++++++++++++++++++++++++---------- 4 files changed, 92 insertions(+), 21 deletions(-) Testing Commands: ----------------- Repeat the test as described in tickets Testing, Expected Results: -------------------------- Only component is successfully active assignment to receive quiesced csi, remove csi. Conditions of Submission: ------------------------- ack from reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
