Hi Neel.

Ack from me.
Not tested.

/AndersBj

-----Original Message-----
From: [email protected] [mailto:[email protected]] 
Sent: den 30 juli 2015 15:47
To: Anders Björnerstedt; Zoran Milinkovic; [email protected]
Cc: [email protected]
Subject: [PATCH 1 of 1] imm:Decrement sqliteTransLock when BEGIN EXCLUSIVE 
TRANSACTION fails [#1426]

 osaf/libs/common/immsv/immpbe_dump.cc |  1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


There is a chance that NFS/shared-storage may re-attach after few seconds, and 
transaction is not yet started, so decrement the sqliteTransLock in 
pbeBeginTrans which releases the lock

diff --git a/osaf/libs/common/immsv/immpbe_dump.cc 
b/osaf/libs/common/immsv/immpbe_dump.cc
--- a/osaf/libs/common/immsv/immpbe_dump.cc
+++ b/osaf/libs/common/immsv/immpbe_dump.cc
@@ -2909,6 +2909,7 @@ SaAisErrorT pbeBeginTrans(void* db_handl
                LOG_ER("SQL statement ('BEGIN EXCLUSIVE TRANSACTION') failed 
because:\n %s",
                        execErr);
                sqlite3_free(execErr);
+               --sqliteTransLock;
                return SA_AIS_ERR_FAILED_OPERATION;
        }
        return SA_AIS_OK;

------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to