Summary: pyosaf: (Version 3) Add decorated Python bindings for CLM together with basic sample application [#1441] Review request for Trac Ticket(s): #1441 Peer Reviewer(s): [email protected], [email protected], [email protected], [email protected] Pull request to: [email protected] Affected branch(es): 4.7.x Development branch: opensaf-staging
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests n Other y Comments (indicate scope for each "y" above): --------------------------------------------- Updated patch-series after review comments by Srikanth. changeset 23f13a350a4de0f3e7347f4b34465bee262eb972 Author: Johan Mårtensson <[email protected]> Date: Mon, 10 Aug 2015 13:23:31 +0200 pyosaf: Add decorated Python bindings for CLM together with basic sample application [#1441] Add decorated functions for the raw saClm* Python functions like the IMM bindings. The decorated functions are in pyosaf/utils/clm. Also add a basic sample application that tracks when nodes join or leaves the cluster. changeset 8ae11c14cca791f6328e82a3956a1aac4271caf1 Author: Johan Mårtensson <[email protected]> Date: Mon, 10 Aug 2015 16:32:26 +0200 pyosaf: Update the makefiles with the new files [#1441] Add the new files to the makefiles. changeset 32bf3620ceed8c56e91815b1839363440a9ed89f Author: Johan Mårtensson <[email protected]> Date: Tue, 11 Aug 2015 13:08:10 +0200 pyosaf: Add the new clm utils library to the make system [#1441] Adds the new clm utils library to the make system. Test by: mkdir tmp-install-dir ./bootstrap.sh ./configure --enable-python make -j 8 make install DESTDIR=tmp-install-dir ls tmp-install- dir/usr/local/lib/python.2.7/dist-packages/pyosaf/utils/clm/__init__.py changeset 3e821adb0a4fa8a758c8e5a3b0e6aaf0cc151f49 Author: Johan Mårtensson <[email protected]> Date: Tue, 11 Aug 2015 15:30:43 +0200 pyosaf: Add --snapshot and --listen arguments to the CLM listener and extend CLM utils to support this [#1441] Extend the clm-listener sample application with --snapshot and --listen arguments to show how to get the current members and how to track membership. Also extend the clm utils to support this. Verify like this: ./clm-listener --snapshot #Lists the current nodes ./clm-listener --listen #Blocks and prints any changes to the cluster membership list changeset 3b4bfcf61b6df9705d426210a8f527e0de38e194 Author: Johan Mårtensson <[email protected]> Date: Tue, 11 Aug 2015 15:37:04 +0200 pyosaf: Add CLM utils to the rpm spec [#1441] Add the CLM utils to the rpm spec. changeset 860795e480dc62f1c064939786ada9d3fdf55bd1 Author: Johan Mårtensson <[email protected]> Date: Tue, 11 Aug 2015 15:46:26 +0200 pyosaf: Removed un-used imports [#1441] Remove un-used imports in the CLM tool sample application. changeset 58c5326a1a2c1a81fe52f4866b6770faea29ced8 Author: Johan Mårtensson <[email protected]> Date: Thu, 13 Aug 2015 14:34:44 +0200 pyosaf: Correct typos and fix lists for added and removed clm nodes [#1441] Correct typos in the clm-tool sample application and in the clm utils library according to review comments. Also fix the list of added and removed clm nodes to contain ClusterNode with the full information provided by clm but without any need for C marshalling. changeset d1f090152ecac84b5b011465d52060e634503771 Author: Johan Mårtensson <[email protected]> Date: Thu, 13 Aug 2015 14:42:57 +0200 pyosaf: Add a description of clm-tool to the README [#1441] Add a description of the clm-tool sample application to the README. Added Files: ------------ python/pyosaf/utils/clm/__init__.py python/pyosaf/utils/clm/Makefile.am python/samples/clm-listener python/samples/clm-tool Removed Files: -------------- python/samples/clm-listener Complete diffstat: ------------------ Makefile.common | 1 + configure.ac | 1 + opensaf.spec.in | 3 + python/pyosaf/utils/Makefile.am | 6 +- python/pyosaf/utils/clm/Makefile.am | 23 ++++++++ python/pyosaf/utils/clm/__init__.py | 147 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ python/samples/README | 5 + python/samples/clm-tool | 67 +++++++++++++++++++++++++ 8 files changed, 251 insertions(+), 2 deletions(-) Testing Commands: ----------------- Test the clm-tool sample application: ./clm-tool --snapshot # Lists current members of the cluster ./clm-tool --listen # Monitors nodes joining or leaving the cluster Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
