Summary: Not possible to add/remove configuration for one node in one single CCB [#1458] Review request for Trac Ticket(s): 1458 Peer Reviewer(s): AMF devs Pull request to: AMF maintainers Affected branch(es): opensaf-4.6.x, default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 3709b6a6a0c7999b24b5cc7367e4cc3c7b159039 Author: Gary Lee <[email protected]> Date: Tue, 25 Aug 2015 16:20:32 +1000 amfd: allow SU to be created [#1458] allow SU to be created on a non-existent node, as long as that node is also created in the same CCB changeset 7f73e00be00cf7bde4c0b596a64bb4ea15588745 Author: Gary Lee <[email protected]> Date: Tue, 25 Aug 2015 16:20:32 +1000 amfd: allow nodeswbundle to be deleted [#1458] allow all nodeswbundles to be deleted if the node is absent changeset b1d9d614dac3de1eb9d3eedaeb95d318b33da0c5 Author: Gary Lee <[email protected]> Date: Tue, 25 Aug 2015 16:20:32 +1000 amfd: allow nodegroup to be modified [#1458] allow node to be deleted from a nodegroup, even if there are SUs hosted on that node as long as these SUs are also removed in the same CCB changeset a13c65ed91fae89462defd99d6b6cfd40df7f657 Author: Gary Lee <[email protected]> Date: Tue, 25 Aug 2015 16:20:32 +1000 amfd: allow node to be removed [#1458] allow node to be removed if it is also removed from all nodegroups Complete diffstat: ------------------ osaf/services/saf/amf/amfd/node.cc | 44 +++++++++++++++++++++++++++++++++++++++----- osaf/services/saf/amf/amfd/nodegroup.cc | 24 +++++++++++++++--------- osaf/services/saf/amf/amfd/nodeswbundle.cc | 3 +-- osaf/services/saf/amf/amfd/su.cc | 26 ++++++++++++++------------ 4 files changed, 69 insertions(+), 28 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
