Summary:opensaf: prevented cluster re-start on misconfigured slot_id
[#464/#414]
Review request for Trac Ticket(s): #464/#414
Peer Reviewer(s): Mathi/Praveen/Srikanth
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts y
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 0c8174a69b5300a52b038f473785bfbe9297cabb
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Thu, 03 Sep 2015 14:00:16 +0530
opensaf: prevented cluster re-start on misconfigured slot_id [#464/#414]
Issue :
---------
Currently in Opensaf duplicate tipc-id is identified on network and
eventually both controllers crashing and Cluster is going for reboot.
steps to reproduce:
----------------------------
1. Both controllers SC-1,SC-2 are up and
running with SC-1 active and SC-2 standby.
2. Wrongly configure the slot_id
of PL-3 with value 3 (same value as SC-2)
3. Start the opensaf on PL-3.
Fix :
------ Added verify duplicate TIPC node_id check before configuring
TIPC/starting Opensaf
This fix is done using tipc toos Usage: tipc-config command [command
(tipc-config -nt option ) and with in the scope of Opensaf startup
scripts.
Note : This bug can alos fixed TIPC code , once it is available we can
remove this code.
We wishes to check whether the duplicate nodes are present in the
cluster
before adding Opensaf newel configured node, this is accomplished by
adding a dummy node to the TIPC topology and this node has very short
time
limit but will not match any other Opensaf Node configuration.
The use of a dummy Node having the name sequence {1,1,2000} , this
allows
the Opensaf to find the information at start-up by getting existing name
table of cluster by using TIPC module not installed command.
Complete diffstat:
------------------
00-README.conf | 8 ++++++--
osaf/services/infrastructure/nid/scripts/configure_tipc.in | 83
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
2 files changed, 87 insertions(+), 4 deletions(-)
Testing Commands:
-----------------
Bring up Opensaf up to 70 nodes with proper and miss configuration
of slot numbers:
-TIPC with single network interface name, e.g. eth3
TIPC_ETH_IF=eth0
- TIPC with multiple network interface name, e.g. eth3
TIPC_ETH_IF=eth0,eth2
- confuring slot_id up to 70
- confuring subslot_id up to 15 with slot_id up to 15
Testing, Expected Results:
--------------------------
Opensaf Startup should work properly and cluster should not go for reboot
in case of miss configuration of slot in above condition
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Monitor Your Dynamic Infrastructure at Any Scale With Datadog!
Get real-time metrics from all of your servers, apps and tools
in one place.
SourceForge users - Click here to start your Free Trial of Datadog now!
http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
