Ack with minor comments.
1. Page 19, numbering for "Service Dependencies" is off. In previous version, it was numbered "3.4 Service Dependencies". Not sure it is your intention or not. 2. In page 19, "Initial configuration can be made by defining a configuration object off the OpenSafLogConfig class." "object off". Seems it "off" is a typo (?) 3. In page 21, there is an error reference. [.] The actual configuration can be read using a corresponding runtime object. See section Error: Reference source not found 4. In Table 4, page 21 "Log server must be member of group or Empty or empty string means function not used" "or empty string". Seems it "or" is a typo (?). 5. Seems "Content"/"List of Tables" in page 9/10 have not been updated. E.g: - Title of section 3.4.1.3 is "Reading log service configuration", but in "Content" it shifts to 3.5.2.4 - Caption of table 7 is "Date tokens", but in the "List of Tables", it shows "Date and time tokens" /Vu From: Lennart Lund [mailto:[email protected]] Sent: Wednesday, September 02, 2015 5:24 PM To: [email protected]; Vu Nguyen M; Giang Do T Cc: [email protected] Subject: Review Request for log document: Update PR document with changes from latest enhancements [#1468] Summary: Update PR document with changes from latest enhancements Trac Ticket(s): #1468 Peer Reviewer(s): <mailto:[email protected]> [email protected], [email protected], [email protected] -------------------------------- Impacted area Impact y/n -------------------------------- Docs y Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- Update Programmers Reference with the changes and new features introduced via the following tickets: [#1316], [#1393], [#593] and [#1288] Marked document and Mercurial patch are attached ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
