Hi,
Ack for all except #7 and #10.
Thanks
-Nagu
> -----Original Message-----
> From: Hans Nordeback [mailto:[email protected]]
> Sent: 14 August 2015 20:20
> To: Praveen Malviya; Nagendra Kumar; [email protected]
> Cc: [email protected]
> Subject: [PATCH 00 of 10] Review Request for amfd: Convert AMF structs to
> classes [#1142]
>
> Summary: amfd: Convert AMF structs to classes
> Review request for Trac Ticket(s): #1142
> Peer Reviewer(s): Nagu, Praveen, Gary
> Pull request to:
> Affected branch(es): default
> Development branch: default
>
> --------------------------------
> Impacted area Impact y/n
> --------------------------------
> Docs n
> Build system n
> RPM/packaging n
> Configuration files n
> Startup scripts n
> SAF services y
> OpenSAF services n
> Core libraries n
> Samples n
> Tests n
> Other n
>
>
> Comments (indicate scope for each "y" above):
> ---------------------------------------------
> <<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
>
> changeset e5fd6622461c3a289659be94249d6c0ad1a1a7ac
> Author: Hans Nordeback <[email protected]>
> Date: Fri, 14 Aug 2015 15:50:33 +0200
>
> amfd: Make AVD_COMP a class, V2 [#1142]
>
> changeset eb696ee1c9b79cd6f582cb18a080f021c58fdb36
> Author: Hans Nordeback <[email protected]>
> Date: Fri, 14 Aug 2015 16:04:09 +0200
>
> amfd: Make AVD_CTCS_TYPE a class, V2 [#1142]
>
> changeset 7275ed7591e362da20d47a0835625c6f83dd9808
> Author: Hans Nordeback <[email protected]>
> Date: Fri, 14 Aug 2015 16:08:17 +0200
>
> amfd: Make AVD_COMP_TYPE a class, V3 [#1142]
>
> changeset f72d59f95ccdeff557b189d70daa4d9a9a2ee4d5
> Author: Hans Nordeback <[email protected]>
> Date: Fri, 14 Aug 2015 16:14:09 +0200
>
> amfd: Make AVD_CS_TYPE a class, V2 [#1142]
>
> changeset 97522ae7d9c3ee5124b11820c431f58535a811cf
> Author: Hans Nordeback <[email protected]>
> Date: Fri, 14 Aug 2015 16:14:13 +0200
>
> amfd: Make AVD_CSI a class, V2 [#1142]
>
> changeset 05412e2aff078ac78165e217a3fc53dab9b429eb
> Author: Hans Nordeback <[email protected]>
> Date: Fri, 14 Aug 2015 16:16:28 +0200
>
> amfd: Make AVD_AVND a class, V2 [#1142]
>
> changeset 39dd407cd5533dfd4084f0a1ab7d23c951ebcce0
> Author: Hans Nordeback <[email protected]>
> Date: Fri, 14 Aug 2015 16:24:23 +0200
>
> amfd: Make AVD_AMF_SG_TYPE a class [#1142]
>
> changeset 405a89094540de8c596f8bb43c3f309699c369de
> Author: Hans Nordeback <[email protected]>
> Date: Fri, 14 Aug 2015 16:26:25 +0200
>
> amfd: Make AVD_SVC_TYPE_CS_TYPE a class [#1142]
>
> changeset 7e74a5579f6e86da300afe16a4296a3428f5d42c
> Author: Hans Nordeback <[email protected]>
> Date: Fri, 14 Aug 2015 16:30:00 +0200
>
> amfd: Make AVD_SVC_TYPE a class [#1142]
>
> changeset 14f1fe26b5e9f98049d7812c2bd8a13cb9cffd62
> Author: Hans Nordeback <[email protected]>
> Date: Fri, 14 Aug 2015 16:33:53 +0200
>
> amfd: Make AVD_SUTYPE a class [#1142]
>
>
> Complete diffstat:
> ------------------
> osaf/services/saf/amf/amfd/comp.cc | 63 ++++++++++---
> osaf/services/saf/amf/amfd/comptype.cc | 12 +-
> osaf/services/saf/amf/amfd/csi.cc | 13 +-
> osaf/services/saf/amf/amfd/cstype.cc | 31 +++--
> osaf/services/saf/amf/amfd/ctcstype.cc | 12 +-
> osaf/services/saf/amf/amfd/include/cb.h | 6 +-
> osaf/services/saf/amf/amfd/include/comp.h | 202
> ++++++++++++++++++++++++------------------
> osaf/services/saf/amf/amfd/include/csi.h | 80 ++++++++++------
> osaf/services/saf/amf/amfd/include/msg.h | 32 +++---
> osaf/services/saf/amf/amfd/include/node.h | 102
> +++++++++++----------
> osaf/services/saf/amf/amfd/include/pg.h | 8 +-
> osaf/services/saf/amf/amfd/include/sg.h | 15 +-
> osaf/services/saf/amf/amfd/include/sgtype.h | 39 +++++---
> osaf/services/saf/amf/amfd/include/si.h | 13 +-
> osaf/services/saf/amf/amfd/include/su.h | 13 +-
> osaf/services/saf/amf/amfd/include/sutcomptype.h | 2 +-
> osaf/services/saf/amf/amfd/include/sutype.h | 24 +++-
> osaf/services/saf/amf/amfd/include/svctype.h | 22 ++-
> osaf/services/saf/amf/amfd/include/svctypecstype.h | 21 ++-
> osaf/services/saf/amf/amfd/include/util.h | 40 ++++----
> osaf/services/saf/amf/amfd/node.cc | 81 ++++++++++++----
> osaf/services/saf/amf/amfd/sg.cc | 1 -
> osaf/services/saf/amf/amfd/sgtype.cc | 86 +++++++----------
> osaf/services/saf/amf/amfd/si.cc | 9 +-
> osaf/services/saf/amf/amfd/su.cc | 12 +-
> osaf/services/saf/amf/amfd/sutcomptype.cc | 2 +-
> osaf/services/saf/amf/amfd/sutype.cc | 108
> +++++++++-------------
> osaf/services/saf/amf/amfd/svctype.cc | 83 +++++++----------
> osaf/services/saf/amf/amfd/svctypecstypes.cc | 10 +-
> 29 files changed, 633 insertions(+), 509 deletions(-)
>
>
> Testing Commands:
> -----------------
> <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>>
>
>
> Testing, Expected Results:
> --------------------------
> <<PASTE COMMAND OUTPUTS / TEST RESULTS>>
>
>
> Conditions of Submission:
> -------------------------
> <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
>
>
> Arch Built Started Linux distro
> -------------------------------------------
> mips n n
> mips64 n n
> x86 n n
> x86_64 y y
> powerpc n n
> powerpc64 n n
>
>
> Reviewer Checklist:
> -------------------
> [Submitters: make sure that your review doesn't trigger any checkmarks!]
>
>
> Your checkin has not passed review because (see checked entries):
>
> ___ Your RR template is generally incomplete; it has too many blank entries
> that need proper data filled in.
>
> ___ You have failed to nominate the proper persons for review and push.
>
> ___ Your patches do not have proper short+long header
>
> ___ You have grammar/spelling in your header that is unacceptable.
>
> ___ You have exceeded a sensible line length in your headers/comments/text.
>
> ___ You have failed to put in a proper Trac Ticket # into your commits.
>
> ___ You have incorrectly put/left internal data in your comments/files
> (i.e. internal bug tracking tool IDs, product names etc)
>
> ___ You have not given any evidence of testing beyond basic build tests.
> Demonstrate some level of runtime or other sanity testing.
>
> ___ You have ^M present in some of your files. These have to be removed.
>
> ___ You have needlessly changed whitespace or added whitespace crimes
> like trailing spaces, or spaces before tabs.
>
> ___ You have mixed real technical changes with whitespace and other
> cosmetic code cleanup changes. These have to be separate commits.
>
> ___ You need to refactor your submission into logical chunks; there is
> too much content into a single commit.
>
> ___ You have extraneous garbage in your review (merge commits etc)
>
> ___ You have giant attachments which should never have been sent;
> Instead you should place your content in a public tree to be pulled.
>
> ___ You have too many commits attached to an e-mail; resend as threaded
> commits, or place in a public tree for a pull.
>
> ___ You have resent this content multiple times without a clear indication
> of what has changed between each re-send.
>
> ___ You have failed to adequately and individually address all of the
> comments and change requests that were proposed in the initial review.
>
> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
>
> ___ Your computer have a badly configured date and time; confusing the
> the threaded patch review.
>
> ___ Your changes affect IPC mechanism, and you don't present any results
> for in-service upgradability test.
>
> ___ Your changes affect user manual and documentation, your patch series
> do not contain the patch that updates the Doxygen manual.
>
------------------------------------------------------------------------------
Monitor Your Dynamic Infrastructure at Any Scale With Datadog!
Get real-time metrics from all of your servers, apps and tools
in one place.
SourceForge users - Click here to start your Free Trial of Datadog now!
http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
