Summary: amfd: convert AVD_SG_OPER to std::list V2 [#1142] Review request for Trac Ticket(s): #1142 Peer Reviewer(s): AMF devs Pull request to: Hans Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 478e9660352746652f9599438f06f7268382e9c0 Author: Gary Lee <[email protected]> Date: Fri, 11 Sep 2015 16:56:28 +1000 amfd: convert AVD_SG_OPER to std::list [#1142] changeset 0bb5dd69b861a11b9ffeef38eb77a92ff033a374 Author: Gary Lee <[email protected]> Date: Fri, 11 Sep 2015 16:56:28 +1000 amfd: convert AVD_SG_OPER to std::list [#1142] also convert some functions to members of various SG classes changeset bc46ca1af13079dc6a1e76b10d53faaa33630412 Author: Gary Lee <[email protected]> Date: Fri, 11 Sep 2015 16:56:28 +1000 amfd: convert AVD_SG_OPER to std::list [#1142] changeset ca77fe2eca860fc5f4d98a9e211f8f9bfbaaa877 Author: Gary Lee <[email protected]> Date: Fri, 11 Sep 2015 16:56:28 +1000 amfd: convert AVD_SG_OPER to std::list [#1142] changeset 9d46ae7925ee43389eb0038964909bec0300f243 Author: Gary Lee <[email protected]> Date: Fri, 11 Sep 2015 16:56:28 +1000 amfd: convert AVD_SG_OPER to std::list [#1142] changeset fde2b6bcd23660fe82614becaa70c8573b8cd5d6 Author: Gary Lee <[email protected]> Date: Fri, 11 Sep 2015 16:56:28 +1000 amfd: convert AVD_SG_OPER to std::list [#1142] changeset b94fdb57c67b4812c802dc82a6dd2d96792c735f Author: Gary Lee <[email protected]> Date: Fri, 11 Sep 2015 17:05:57 +1000 amfd: convert AVD_SG_OPER to std::list [#1142] also convert some static functions to members of SG_NPM changeset 4089eaeb6d0ecdd7ed39b3a17614dbaa1d617976 Author: Gary Lee <[email protected]> Date: Fri, 11 Sep 2015 17:05:58 +1000 amfd: convert AVD_SG_OPER to std::list [#1142] also convert some static functions to members of AVG_NWAY changeset ff7ab1feaf51201b4af902214f2967c12a024cbd Author: Gary Lee <[email protected]> Date: Fri, 11 Sep 2015 17:05:58 +1000 amfd: convert AVD_SG_OPER to std::list [#1142] changeset 0079568f1b670f54c32c9912409ccb1ebc6e2a7a Author: Gary Lee <[email protected]> Date: Fri, 11 Sep 2015 17:05:58 +1000 amfd: convert AVD_SG_OPER to std::list [#1142] Complete diffstat: ------------------ osaf/services/saf/amf/amfd/ckpt_enc.cc | 7 ++----- osaf/services/saf/amf/amfd/include/sg.h | 34 ++++++++++++++++++++++++++++++---- osaf/services/saf/amf/amfd/sg.cc | 36 ++++++++++++++++++++++++------------ osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 119 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------------------- osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 78 ++++++++++++++++++++++++++++++++++-------------------------------------------- osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 126 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------- osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 127 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------- osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 48 ++++++++++++++++++++---------------------------- osaf/services/saf/amf/amfd/sgproc.cc | 90 ++++++++++++++++++++++-------------------------------------------------------------------- osaf/services/saf/amf/amfd/si_dep.cc | 4 ++-- 10 files changed, 328 insertions(+), 341 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
