Please find response inlined. Thanks -Nagu
> -----Original Message----- > From: Gary Lee [mailto:[email protected]] > Sent: 07 September 2015 11:16 > To: Nagendra Kumar; [email protected]; Praveen Malviya > Cc: [email protected] > Subject: Re: [PATCH 10 of 13] amfd: convert list_of_su to std::set [#1142] > > Hi Nagu > > Thanks very much for the comments. Please see [GL] below. > > On 04/09/15 23:39, Nagendra Kumar wrote: > > Please find comment inlined with [Nagu]. > > > > Thanks > > -Nagu > > > >> -----Original Message----- > >> From: Gary Lee [mailto:[email protected]] > >> Sent: 30 July 2015 11:01 > >> To: [email protected]; Praveen Malviya; Nagendra Kumar; > >> [email protected] > >> Cc: [email protected] > >> Subject: [PATCH 10 of 13] amfd: convert list_of_su to std::set [#1142] > >> > >> osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 69 > >> +++++++++----------------- > --- > >> 1 files changed, 21 insertions(+), 48 deletions(-) > >> > >> > >> diff --git a/osaf/services/saf/amf/amfd/sg_nored_fsm.cc > >> b/osaf/services/saf/amf/amfd/sg_nored_fsm.cc > >> --- a/osaf/services/saf/amf/amfd/sg_nored_fsm.cc > >> +++ b/osaf/services/saf/amf/amfd/sg_nored_fsm.cc > >> @@ -37,18 +37,15 @@ > >> * no assignments need to happen. > >> */ > >> AVD_SU *SG_NORED::assign_sis_to_sus() { > >> - AVD_SU *i_su; > >> AVD_SI *i_si; > >> - bool l_flag; > >> AVD_SU_SI_REL *tmp; > >> > >> TRACE_ENTER(); > >> > >> i_si = list_of_si; > >> - i_su = list_of_su; > >> > >> avd_sidep_update_si_dep_state_for_all_sis(this); > > [Nagu]: Logic of assignment is broken here. Now one SI is getting assigned > > to > many SUs for No Red. > > > > [GL] I'm not sure I see the problem here. There is a 'break' if an > assignment occurs, it moves onto the next SI. [Nagu]: Yes, got it. I missed break. One additional thing can be done : When Su hits end, then outer for loop should be given a break because there is no SU to be assigned so looping across the SI is not giving anything. > > Thanks > Gary > ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
