ummary: ckpd: enhanced trace log and check of user parameters
Review request for Trac Ticket(s): 1224
Peer Reviewer(s): [email protected], Ingvar Bergström
<[email protected]>
Pull request to: [email protected]
Affected branch(es): default(4.7)
Development branch: default(4.7)
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Enhance ckpt service with message tracing. Following is an example of tracing:
TR cpnd <<== CPND_EVT_A2ND_CKPT_OPEN(hdl=1, safCkpt=cp1) from node 0x2050F
TR cpnd ==>> CPD_EVT_ND2D_CKPT_CREATE(safCkpt=cp1, creationFlags=0x1) to node
0x0
TR cpnd <<== [1] CPND_EVT_D2ND_CKPT_INFO(err=1, active=0x2050F,
create_rep=true) from node 0x0
TR cpnd ==>> CPA_EVT_ND2A_CKPT_OPEN_RSP(err=1, active=0x2050F, gbl_hdl=1,
lcl_hdl=0XE6A930) to node 0x2050F
TR cpnd <<== [1] CPND_EVT_ND2ND_CKPT_SYNC_REQ(hdl=0, open=false) from node
0x2010F
TR cpnd <<== [1] CPND_EVT_D2ND_CKPT_REP_ADD(dest=0x2010F, active=0x0,
restart=false, dest_cnt=0) from node 0x0
TR cpnd <<== [1] CPND_EVT_ND2ND_CKPT_SYNC_REQ(hdl=0, open=false) from node
0x2020F
TR cpnd <<== [1] CPND_EVT_D2ND_CKPT_REP_ADD(dest=0x2020F, active=0x0,
restart=false, dest_cnt=0) from node 0x0
TR cpnd <<== [1] CPND_EVT_D2ND_CKPT_REP_ADD(dest=0x2050F, active=0x0,
restart=false, dest_cnt=0) from node 0x0
Legend:
<<== : Receive message
==>> : Send message
[x] : Checkpoint ID
Complete diffstat:
------------------
osaf/libs/agents/saf/cpa/cpa_mds.c | 10 +-
osaf/libs/agents/saf/cpa/cpa_proc.c | 4 +
osaf/libs/common/cpsv/cpsv_evt.c | 838
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
osaf/libs/common/cpsv/include/cpsv_evt.h | 2 +
osaf/services/saf/cpsv/cpd/cpd_db.c | 1 +
osaf/services/saf/cpsv/cpd/cpd_evt.c | 3 +
osaf/services/saf/cpsv/cpd/cpd_mds.c | 24 ++++-
osaf/services/saf/cpsv/cpd/cpd_proc.c | 3 +-
osaf/services/saf/cpsv/cpnd/cpnd_evt.c | 9 +-
osaf/services/saf/cpsv/cpnd/cpnd_mds.c | 32 ++++++-
10 files changed, 918 insertions(+), 8 deletions(-)
Testing Commands:
-----------------
- Open checkpoint and verify tracing
Testing, Expected Results:
--------------------------
- Example of tracing log:
TR cpnd <<== CPND_EVT_A2ND_CKPT_OPEN(hdl=1, safCkpt=cp1) from node 0x2050F
TR cpnd ==>> CPD_EVT_ND2D_CKPT_CREATE(safCkpt=cp1, creationFlags=0x1) to node
0x0
TR cpnd <<== [1] CPND_EVT_D2ND_CKPT_INFO(err=1, active=0x2050F,
create_rep=true) from node 0x0
TR cpnd ==>> CPA_EVT_ND2A_CKPT_OPEN_RSP(err=1, active=0x2050F, gbl_hdl=1,
lcl_hdl=0XE6A930) to node 0x2050F
TR cpnd <<== [1] CPND_EVT_ND2ND_CKPT_SYNC_REQ(hdl=0, open=false) from node
0x2010F
TR cpnd <<== [1] CPND_EVT_D2ND_CKPT_REP_ADD(dest=0x2010F, active=0x0,
restart=false, dest_cnt=0) from node 0x0
TR cpnd <<== [1] CPND_EVT_ND2ND_CKPT_SYNC_REQ(hdl=0, open=false) from node
0x2020F
TR cpnd <<== [1] CPND_EVT_D2ND_CKPT_REP_ADD(dest=0x2020F, active=0x0,
restart=false, dest_cnt=0) from node 0x0
TR cpnd <<== [1] CPND_EVT_D2ND_CKPT_REP_ADD(dest=0x2050F, active=0x0,
restart=false, dest_cnt=0) from node 0x0
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
