Summary: amfd: convert list_of_su to std::set V2 [#1142]
Review request for Trac Ticket(s): 1142
Peer Reviewer(s): AMF devs
Pull request to:
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset e8e4f89e29a957538ccc0dbd108e5c7eb97c28fa
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 14 Sep 2015 19:10:02 +1000
amfd: convert list_of_su to std::set [#1142]
changeset 9836ae9a9d197ba8ee7c6d5f06f26fba431879d0
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 14 Sep 2015 19:10:02 +1000
amfd: convert list_of_su to std::set [#1142]
changeset 8c1ccb4da1730121075ea1cae966e97a9d204732
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 14 Sep 2015 19:10:02 +1000
amfd: convert list_of_su to std::set [#1142]
changeset 48122c0e543ea7b50839c861b65eb71662da2c0c
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 14 Sep 2015 19:10:02 +1000
amfd: convert list_of_su to std::set [#1142]
changeset 49f4840559efc786136aad8e77643eaf8dafd17c
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 14 Sep 2015 19:10:02 +1000
amfd: convert list_of_su to std::set [#1142]
changeset 7382241988b549ef4c384779dc3f116fcb97e924
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 14 Sep 2015 19:10:02 +1000
amfd: convert list_of_su to std::set [#1142]
changeset de45c4afcdbf71e14e8f2f140c85c6b16f53e9a8
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 14 Sep 2015 19:10:02 +1000
amfd: convert list_of_su to std::set [#1142]
changeset bee5e342445b0ff35dccf83280a0132d9c3093be
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 14 Sep 2015 19:10:03 +1000
amfd: convert list_of_su to std::set [#1142]
changeset 2ff692b76677ecb11ffe74cffca0a531db02ef32
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 14 Sep 2015 19:10:03 +1000
amfd: convert list_of_su to std::set [#1142]
changeset 3a4df7f29aefaf94c1c4a9736d76b8d4ff403f43
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 14 Sep 2015 20:26:05 +1000
amfd: convert list_of_su to std::set [#1142]
changeset e3038fa9dc70ecad5039e910115440df38b0f163
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 14 Sep 2015 20:26:08 +1000
amfd: convert list_of_su to std::set [#1142]
changeset 1b93bd5b6d839c2ab12959c2c5ce2af40c7784b7
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 14 Sep 2015 20:26:08 +1000
amfd: convert list_of_su to std::set [#1142]
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/cluster.cc | 2 +-
osaf/services/saf/amf/amfd/include/sg.h | 13 ++++-
osaf/services/saf/amf/amfd/include/su.h | 15 ++++++-
osaf/services/saf/amf/amfd/node.cc | 9 +---
osaf/services/saf/amf/amfd/nodegroup.cc | 4 +-
osaf/services/saf/amf/amfd/sg.cc | 176
++++++++++++++++++++++++++++++++++++++++-------------------------------------------
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 98
++++++++++++++++++++-------------------------
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 72
++++++++++++---------------------
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 292
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------------------
osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 53 +++++++++++++++---------
osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 49 ++++++++++------------
osaf/services/saf/amf/amfd/sgproc.cc | 25 ++++-------
osaf/services/saf/amf/amfd/su.cc | 5 +-
13 files changed, 401 insertions(+), 412 deletions(-)
Testing Commands:
-----------------
<<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>>
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
