Summary: logsv: fix logsv gets stuck in a loop if passing zero(0) to maxFilesRotated [#1399] Review request for Trac Ticket(s): #1399 Peer Reviewer(s): [email protected]; [email protected] Pull request to: [email protected] Affected branch(es): 4.5, 4.6, default Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset aa6d7ec1b36c56e73317eae100cc0d6e3e212825 Author: Vu Minh Nguyen <[email protected]> Date: Tue, 01 Sep 2015 07:17:12 +0100 logsv: fix logsv gets stuck in a loop if passing zero(0) to maxFilesRotated [#1399] Log agent and logsv do not validate this input when openning stream using LOG API. Fix this defect by adding validation in the log agent as well as logsv. Complete diffstat: ------------------ osaf/libs/agents/saf/lga/lga_api.c | 10 +++++++++- osaf/services/saf/logsv/lgs/lgs_evt.c | 9 +++++++++ tests/logsv/tet_LogOiOps.c | 23 +++++++++++++++++++++++ tests/logsv/tet_saLogStreamOpen_2.c | 103 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 144 insertions(+), 1 deletions(-) Testing Commands: ----------------- For test cases were added. They are test case 46, 47 @ suite 2 and test case 15 @ suite 6. Run these test cases to test this patch. E.g: logtest 2 46 logtest 2 47 logtest 6 15 Testing, Expected Results: -------------------------- All added test cases PASS Conditions of Submission: ------------------------- Get ack from peer reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Monitor Your Dynamic Infrastructure at Any Scale With Datadog! Get real-time metrics from all of your servers, apps and tools in one place. SourceForge users - Click here to start your Free Trial of Datadog now! http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
