Summary: amfd: support si-swap admin op for Nway model [#78] Review request for Trac Ticket(s): #78 Peer Reviewer(s): AMF contributors Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): Default Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 23fcfdbfa1df28f13bf6b46577cab4a5e0a757c7 Author: [email protected] Date: Wed, 16 Sep 2015 16:13:04 +0530 amfd: support si-swap admin op for Nway model [#78] Currently si-swap is allowed on a SI that is protected by a 2N SG. As per spec, operation is valid for NWAY and NPM model also. This patch supports si-swap admin op for Nway model with following restrictions: 1)Operation will be rejected if Equal distribution feature is enabled. 2)operation will be rejected if SIRankedSU is configured and AutoAdjust flag is enabled. However it will be allowed if AutoAdjust is disabled. Reason for rejecting the operation in above two cases: In both of these cases AutoAdjust flag is eanbled and is used to partially adjust the SG. At the same time, autoadjust feature is used without using autoadjustprob timer. In the equal distribution cases both active assignments and standby assignments are equally distributed among the available SUs without waiting for any autoadjustprob timer expiry. Thus if si-swap is supported in this case, SG will be adjusted to same configuration. Same explanation is valid for other case also. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/include/sg.h | 1 + osaf/services/saf/amf/amfd/include/su.h | 2 + osaf/services/saf/amf/amfd/sg.cc | 2 + osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 101 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-- osaf/services/saf/amf/amfd/si.cc | 2 +- osaf/services/saf/amf/amfd/su.cc | 32 ++++++++++++++++++++ 6 files changed, 135 insertions(+), 5 deletions(-) Testing Commands: ----------------- No SirankedsU confs: Si-swap with surank different Si-swap with surank same Si-swap with surank different and auto adjust set Si-swap with surank same and auto adjust set. Siranked su confs: Si-swap in with surank different Si-swap in with surank same Si-swap in with surank different and auto adjust set Si-swap in with surank same and auto adjust set Si-swap in with surank different and sirnked reverse Si-swap in with surank same and siranked reverse Si-swap in with surank different and maxactiveSIperSU=1 Si-swap in with surank different and maxstandbySIperSU=1 Si-swap in with surank different and both maxactiveSIperSU=maxstandbySIperSU=1. Si-swap when MaxActiveSIsperSU reached. Si-swap when MaxStandbySIsperSU reached. Controller SO during active mod Controller SO during quiesced mod Controller SO during standby mod Controller FO during active mod Controller FO during quiesced mod Controller FO during standby mod Testing, Expected Results: -------------------------- PASS. Observed rejection of operation in restricted cases. Conditions of Submission: ------------------------- Ack from any reviewer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Monitor Your Dynamic Infrastructure at Any Scale With Datadog! Get real-time metrics from all of your servers, apps and tools in one place. SourceForge users - Click here to start your Free Trial of Datadog now! http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
