Summary: amfd: convert list_of_su to std::vector V3 [#1142] Review request for Trac Ticket(s): 1142 Peer Reviewer(s): AMF devs Pull request to: Hans Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- V3 uses std::vector instead of std::set changeset 5844dfdba740908f0af14117988fe12fc835080b Author: Gary Lee <[email protected]> Date: Thu, 17 Sep 2015 15:18:12 +1000 amfd: convert list_of_su to std::vector [#1142] changeset f9d30cebec182b291aad7be510b2752be71b9562 Author: Gary Lee <[email protected]> Date: Thu, 17 Sep 2015 15:18:12 +1000 amfd: convert list_of_su to std::vector [#1142] changeset 69723d58e7bb34a2b75123794b757c8626d9b180 Author: Gary Lee <[email protected]> Date: Thu, 17 Sep 2015 15:18:12 +1000 amfd: convert list_of_su to std::vector [#1142] changeset e709077f4d274ab9cd6230e4c3b4c6f11adf9c92 Author: Gary Lee <[email protected]> Date: Thu, 17 Sep 2015 15:18:12 +1000 amfd: convert list_of_su to std::vector [#1142] changeset 3a42351aa2e3049f0040613a787a882ea5fa6147 Author: Gary Lee <[email protected]> Date: Thu, 17 Sep 2015 15:18:12 +1000 amfd: convert list_of_su to std::vector [#1142] changeset 3007b1b7d23296d35479339c454adcf9645de13b Author: Gary Lee <[email protected]> Date: Thu, 17 Sep 2015 15:18:12 +1000 amfd: convert list_of_su to std::vector [#1142] changeset 93b4f44aaac140f8be4b57f860b008f4f8470f10 Author: Gary Lee <[email protected]> Date: Thu, 17 Sep 2015 15:18:12 +1000 amfd: convert list_of_su to std::vector [#1142] changeset 0b28338c35369c11964d2036477001803ae3693c Author: Gary Lee <[email protected]> Date: Thu, 17 Sep 2015 15:18:12 +1000 amfd: convert list_of_su to std::vector [#1142] changeset 4a73604b47ece1947c3a264697e77fc1cab24017 Author: Gary Lee <[email protected]> Date: Thu, 17 Sep 2015 15:18:18 +1000 amfd: convert list_of_su to std::vector [#1142] changeset 43c3aea1a49ca133383d920774cf76547104c6ef Author: Gary Lee <[email protected]> Date: Thu, 17 Sep 2015 15:18:18 +1000 amfd: convert list_of_su to std::vector [#1142] changeset 9ef2b8bb7015bf47099fdfa0552ff89665203eb4 Author: Gary Lee <[email protected]> Date: Thu, 17 Sep 2015 15:18:18 +1000 amfd: convert list_of_su to std::vector [#1142] changeset 8e9073e892cb832ab02b17858a01f39cbdcfb555 Author: Gary Lee <[email protected]> Date: Thu, 17 Sep 2015 15:18:18 +1000 amfd: convert list_of_su to std::vector [#1142] Complete diffstat: ------------------ osaf/services/saf/amf/amfd/cluster.cc | 2 +- osaf/services/saf/amf/amfd/include/sg.h | 13 +++- osaf/services/saf/amf/amfd/include/su.h | 2 +- osaf/services/saf/amf/amfd/node.cc | 9 +-- osaf/services/saf/amf/amfd/nodegroup.cc | 4 +- osaf/services/saf/amf/amfd/sg.cc | 179 +++++++++++++++++++++++++++++++------------------------------- osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 98 ++++++++++++++------------------- osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 72 +++++++++--------------- osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 307 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------- osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 53 +++++++++++------- osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 51 ++++++++--------- osaf/services/saf/amf/amfd/sgproc.cc | 25 +++----- osaf/services/saf/amf/amfd/su.cc | 5 +- 13 files changed, 408 insertions(+), 412 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Monitor Your Dynamic Infrastructure at Any Scale With Datadog! Get real-time metrics from all of your servers, apps and tools in one place. SourceForge users - Click here to start your Free Trial of Datadog now! http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
