Summary: amfd: fix comp term_failed state alarm [#1473]. Review request for Trac Ticket(s): #1473 Peer Reviewer(s): Hans N, Nagendra,Quyen Dao Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): All Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 76604c258ffafff0055bae7cb6a0cebc7f351858 Author: [email protected] Date: Thu, 17 Sep 2015 19:01:35 +0530 amfd: fix comp term_failed state alarm [#1473] In the reported problem when component enters into TERM_FAILED state during clean up failure, AMFD raises alarm and clears it immediately. In the reported problem saAmfNodeFailfastOnTerminationFailure is set false. When component enters term_failed state AMFD raises alrams on it. When all components are cleaned up, amfnd sends a su-failover request to amfd. As a part of sufailover request amfd marks all the comps uninstantiated and clears any pending alrams on them. Since saAmfNodeFailfastOnTerminationFailure is false, clearence of alarm should be done as a part of repair operation on SU. Even in the case when saAmfNodeFailfastOnTerminationFailure=1, Alarm should be cleared only when AMFD has detected that node has gone for reboot. Patch fixes both the problems. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/su.cc | 14 +++++++++++++- 1 files changed, 13 insertions(+), 1 deletions(-) Testing Commands: ----------------- As per ticket description. Testing, Expected Results: -------------------------- 1)When saAmfNodeFailfastOnTerminationFailure=0, Alarm is cleared as part of repair operation on SU. 2)When saAmfNodeFailfastOnTerminationFailure=1, Alarm is cleared when AMFD detects that node has rebooted. Conditions of Submission: ------------------------- Ack from any reviewer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Monitor Your Dynamic Infrastructure at Any Scale With Datadog! Get real-time metrics from all of your servers, apps and tools in one place. SourceForge users - Click here to start your Free Trial of Datadog now! http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
