Johan,
Nice work. The sample applications depict the usage of different
features in IMMOI in a simple way.
Here are couple of comments.
-> The file python/pyosaf/utils/immoi/Makefile.am is not part of patch
sent. Because of which, compilation fails.
-> As the file python/samples/immoi/samples/README is removed in the
recent patch, is there any plan
to add the usage of the oi samples to the README. The earlier file has
detailed steps and expected results
about how to use the sample.
/ Srikanth
On 09/15/2015 06:04 PM, Johan Mårtensson wrote:
> python/samples/caps | 6 +++---
> python/samples/caps-inheritance-impl | 6 +++---
> python/samples/interface-handler | 2 +-
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
>
> Fix minor issues in the caps and interface sample OIs
>
> diff --git a/python/samples/caps b/python/samples/caps
> --- a/python/samples/caps
> +++ b/python/samples/caps
> @@ -34,9 +34,9 @@ if __name__ == "__main__":
>
> # Parse command line arguments
> parser = argparse.ArgumentParser(
> - description='Validates that the lowerCaps and upperCaps attributes
> -of instances of the CapsSample class can only contain
> -lower case and upper case text respectively.')
> + description='Validates that the lowerCaps and upperCaps attributes'
> + 'of instances of the CapsSample class can only contain'
> + 'lower case and upper case text respectively.')
>
> parser.parse_args()
>
> diff --git a/python/samples/caps-inheritance-impl
> b/python/samples/caps-inheritance-impl
> --- a/python/samples/caps-inheritance-impl
> +++ b/python/samples/caps-inheritance-impl
> @@ -45,9 +45,9 @@ if __name__ == "__main__":
>
> # Parse command line arguments
> parser = argparse.ArgumentParser(
> - description='Validates that the lowerCaps and upperCaps attributes
> -of instances of the CapsSample class can only contain
> -lower case and upper case text respectively.')
> + description='Validates that the lowerCaps and upperCaps attributes'
> + 'of instances of the CapsSample class can only contain'
> + 'lower case and upper case text respectively.')
>
> parser.parse_args()
>
> diff --git a/python/samples/interface-handler
> b/python/samples/interface-handler
> --- a/python/samples/interface-handler
> +++ b/python/samples/interface-handler
> @@ -61,7 +61,7 @@ def create_rt_object_for_interface(imple
> implementer.create(mo)
>
> def select_loop(implementer):
> - print 'select loop'
> +
> # Get selection object for the implementer
> selection_object = implementer.get_selection_object()
>
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
